Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethdb/pebble: don't double-close iterator inside pebbleIterator #273

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

magicxyyz
Copy link
Contributor

Adds released flag to pebbleIterator to avoid double closing cockroachdb/pebble.Iterator as it is an invalid operation.

This PR backports: ethereum/go-ethereum#28566
Fixes: ethereum/go-ethereum#28565

Adds 'released' flag to pebbleIterator to avoid double closing cockroachdb/pebble.Iterator as it is an invalid operation.

Fixes #28565
@cla-bot cla-bot bot added the s label Nov 21, 2023
@magicxyyz magicxyyz marked this pull request as ready for review November 22, 2023 01:46
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit 0a65849 into master Nov 22, 2023
3 checks passed
@PlasmaPower PlasmaPower deleted the backport-pebble-iterator-release branch November 22, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeated call to pebbleIterator.Release accesses memory returned to sync.Pool
2 participants