Fairer Task Queue: Add priority to lifecycle phases and deployments #252
+31
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susanpann
force-pushed
the
susan/taskQueue
branch
from
fc23b3e
to
622fbf3
Compare
tothegills
reviewed
Jun 24, 2024
pkg/deployments/deployment.go
Outdated
| @@ -27,6 +27,7 @@ type Deployment struct { | |||
| FormValues map[string]string `json:"FormValues,omitempty"` | |||
| ManifestVariableSetID string `json:"ManifestVariableSetId,omitempty"` | |||
| Name string `json:"Name,omitempty"` | |||
| Priority string `json:"Priority" binding:"oneof=On Off LifecycleDefault"` | |||
There was a problem hiding this comment.
What happens if this is not set? Is it required? Is there a default?
There was a problem hiding this comment.
At the moment it sets it to an empty string. I've changed it to set the default to LifecycleDefault, with the omitempty tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce priority to lifecycles and deployments
#project-fairer-task-queue
[sc-81601]