Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exported include/libary dirs wrong when paths contain spaces #54

Closed
dirk-thomas opened this issue Nov 1, 2013 · 3 comments
Closed

exported include/libary dirs wrong when paths contain spaces #54

dirk-thomas opened this issue Nov 1, 2013 · 3 comments
Labels
bug

Comments

@dirk-thomas
Copy link

The generated CMake config file does not quote the OCTOMAP_INCLUDE_DIRS / OCTOMAP_LIBRARY_DIRS. In a workspace containing spaces the wrong include/library dirs break downstream packages from finding octomap headers and libraries.
@ahornung
Copy link
Member

ahornung commented Nov 4, 2013

Does this affect a specific release that's problematic and should be updated, or just a general heads-up?

@dirk-thomas
Copy link
Author

I tried it with the latest released version in Hydro. I would say it does not require a re-release since people can just work around it by not using spaces in their paths. But it is good that it is fixed for the future.

@ahornung
Copy link
Member

ahornung commented Nov 4, 2013

OK, thanks for catching this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahornung @dirk-thomas