-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating an idealised example #55
Conversation
Pull main into idealised_example
for more information, see https://pre-commit.ci
…lasticParcels into idealised_example
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
=======================================
Coverage 66.66% 66.66%
=======================================
Files 8 8
Lines 717 717
=======================================
Hits 478 478
Misses 239 239
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…er than importing the functions and creating in script.
for more information, see https://pre-commit.ci
I can't comment on the ipynb file using GitHub tools, so here a list of (minor) comments:
|
I've made a link to the examples page, just using 'see other examples'. Or should we flesh this out more?
I've added to the comment that they come from the Kooi et al, Lobelle et al, and Kaandorp et al papers, with dois.
I'm not sure I understand this one just yet, but maybe there's some refactoring we can do, yep!
I've added a note for cell 10, but have left all the later ones as is. Or should we add the note to each?
I've made it 4dp now. Perhaps we also print the difference? |
Thanks for incorporating these, @michaeldenes. Two more comments on the notebook
|
Thanks @erikvansebille, I've now made these two changes |
This pull-request is to include a new example notebook, using an idealised flow (the Bickley Jet) to show how
plasticparcels
can be used, without the need to download any datasets.With #56 , this is to close #51