core/validatorapi: handle HTTP methods

[gsora]

Instead of handling all HTTP methods for all validator API endpoints, only support a subset of them for each.

Selected the appropriate HTTP method by matching them from the Beacon Node API spec: https://ethereum.github.io/beacon-APIs/#/.

category: bug
ticket: #2835

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e962d4) 53.41% compared to head (8760b79) 53.49%.
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2866      +/-   ##
==========================================
+ Coverage   53.41%   53.49%   +0.08%     
==========================================
  Files         200      200              
  Lines       28059    28088      +29     
==========================================
+ Hits        14989    15027      +38     
+ Misses      11203    11201       -2     
+ Partials     1867     1860       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[xenowits]

Suggested change

	if len(e.Methods) != 0 {
	handler.Methods(e.Methods...)
	}
	handler.Methods(e.Methods...)

i wonder if this could work?

[gsora]

Sadly no:

package main

import (
	"net/http"

	"github.com/gorilla/mux"
)

func main() {
	r := mux.NewRouter()

	r.HandleFunc("/test", func(w http.ResponseWriter, r *http.Request) {
		w.Write([]byte(r.Method))
	}).Methods()

	http.ListenAndServe(":9999", r)
}

This demo simulates the case in which e.Methods is empty.

If you curl -v http://localhost:9999/test you'll see that the answer is status 405.

[xenowits]

is there any endpoint that doesn't have a list of accepted methods? In that case, I think a test case for such an endpoint could make sense

But, I believe you have added either GET or a POST to all the endpoints

[gsora]

Correct, we must always specify the list of supported methods for each VAPI endpoint.

[xenowits]

LGTM!

[pinebit]

LGTM

[sonarcloud]

Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
4.6% Duplication on New Code

See analysis details on SonarCloud

[dB2510]

why a slice rather than a string? In this case, we will need to write a single handler which will handle all the http statuses. But if specify just one method per endpoint then we can separate handlers for each method which might be more clean than the current approach. WDYT?

[gsora]

Generally when designing APIs like this I found that one might want to handle the same endpoint in different HTTP methods.

[gsora]

For reference, gorilla/mux does this as well, using a variadic argument for handler.Methods.