Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More generic read/write api #14

Merged
merged 2 commits into from
Apr 17, 2020
Merged

More generic read/write api #14

merged 2 commits into from
Apr 17, 2020

Conversation

Jonathas-Conceicao
Copy link
Member

Require just Read and Write for input arguments and drop the 'static requirement for Read.

This allows, for one, the use of slices as write targets for uncompress_file, a (doc) test as been added for it to avoid regression bugs.

This should not be a breaking change since we have that impl<'_, W: Write + ?Sized> Write for &'_ mut W and impl<'_, R: Read + ?Sized> Read for &'_ mut R.

Jonathas-Conceicao added 2 commits April 17, 2020 10:00
Signed-off-by: Jonathas-Conceicao <jonathas.conceicao@ossystems.com.br>
Require just `Read` and `Write` for input arguments and drop the `'static`
requirement for `Read`.

Signed-off-by: Jonathas-Conceicao <jonathas.conceicao@ossystems.com.br>
@github-actions
Copy link

Pull Request Test Coverage Report for Build c65cc49703a70b6bf6baa0f04e8d1e39e705cdd1-PR-14

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 44.681%

Totals Coverage Status
Change from base Build 1e7286845c6444b0a04110dd44e0278fc57c7cc4: 0.0%
Covered Lines: 21
Relevant Lines: 47

💛 - Coveralls

@otavio otavio merged commit 1b6222a into master Apr 17, 2020
@otavio otavio deleted the topic/more_generic_api branch April 17, 2020 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants