Add support for private encodeable factory in server initialization #3366
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Servers running in the same process as clients can now use isolated encodeable factories, preventing type registration conflicts. When a server registers custom types, clients in the same process previously could see these types and skip loading them via the complex type system.
API Changes
ServiceMessageContext(ITelemetryContext, IEncodeableFactory)- new constructor accepting a private factoryApplicationConfiguration.CreateMessageContext(IEncodeableFactory)- new overload for private factoryApplicationConfiguration.CreateMessageContext(bool)- marked obsolete (parameter was never used)ServerBase.PrivateEncodeableFactory- new property to set private factory before server startupUsage
Related Issues
Types of changes
Checklist
Further comments
The existing
CreateMessageContext(bool clonedFactory)parameter was never implemented—it was always ignored. This change deprecates it in favor of explicit factory injection, which provides actual isolation guarantees.Internal callers (Session, DefaultSessionFactory, GDS clients) updated to use the new parameterless
CreateMessageContext().Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.