Skip to content

Conversation

@mrsuciu
Copy link
Contributor

@mrsuciu mrsuciu commented Nov 24, 2025

Proposed changes

The reference value for the stateOrProvinceName attribute of a Distinguished Name is "ST".
It appears that Microsoft is using a nonstandard abbreviation for the stateOrProvinceName attribute as being "S".
This PR normalizes them so that the X509Utils.CompareDistinguishedNameFields would match two identifiers of values "S" and "ST".

Related Issues

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.00%. Comparing base (d25caff) to head (ab64229).
⚠️ Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
...ack/Opc.Ua.Core/Security/Certificates/X509Utils.cs 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3358      +/-   ##
==========================================
+ Coverage   51.86%   60.00%   +8.13%     
==========================================
  Files         370      371       +1     
  Lines       78618    78225     -393     
  Branches    13650    13602      -48     
==========================================
+ Hits        40779    46940    +6161     
+ Misses      33705    26977    -6728     
- Partials     4134     4308     +174     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

X509Utils.CompareDistinguishedNameFields Failing a Valid SubjectName Comparison

2 participants