Skip to content

Conversation

@mrsuciu
Copy link
Contributor

@mrsuciu mrsuciu commented Apr 18, 2025

Add version System.Diagnostics.DiagnosticSource to match Microsoft.Extensions.Logging.Abstractions version, should improve Dependabot runtime dependency resolutions ...

Proposed changes

Dependabot shows multiple failing errors:

error NU1605: Warning As Error: Detected package downgrade: System.Diagnostics.DiagnosticSource from 9.0.1 to 6.0.2. Reference the package directly from the project to select a different version
/tmp/package-dependency-resolution_iKlVQb/Project.csproj : error NU1605:  Project -> Microsoft.Extensions.Logging.Abstractions 9.0.1 -> System.Diagnostics.DiagnosticSource (>= 9.0.1) 
/tmp/package-dependency-resolution_iKlVQb/Project.csproj : error NU1605:  Project -> System.Diagnostics.DiagnosticSource (= 6.0.2)
  Failed to restore /tmp/package-dependency-resolution_iKlVQb/Project.csproj (in 220 ms).

which apparently stem from it not knowing to resolve the System.Diagnostics.DiagnosticSource to match the Microsoft.Extensions.Logging.Abstractions 9.0.1 version.

This might speed up the dependabot runtime.

Related Issues

  • Fixes #

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@mrsuciu mrsuciu requested a review from romanett April 18, 2025 19:21
@codecov
Copy link

codecov bot commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.03%. Comparing base (6a1b269) to head (2dafb07).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3061      +/-   ##
==========================================
- Coverage   57.04%   57.03%   -0.01%     
==========================================
  Files         357      357              
  Lines       68951    68951              
  Branches    14156    14156              
==========================================
- Hits        39330    39325       -5     
+ Misses      25386    25382       -4     
- Partials     4235     4244       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mrsuciu mrsuciu merged commit d5fd96b into OPCFoundation:master Apr 20, 2025
74 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants