Skip to content

Conversation

@romanett
Copy link
Contributor

@romanett romanett commented Apr 8, 2025

  • Make ValidateRolePermissions virtual in CustomNodeManager.cs to allow custom validation
  • Initialize OperationContext in Node.ReadAttribute of MonitoredNode to allow custom validation
  • Update ValidateRolePermissions in MasterNodeManager.cs to prevent null reference exception

Related Issues

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

- Make `ValidateRolePermissions` virtual in `CustomNodeManager.cs` to allow custom validation
- Initialize OperationContext in Node.ReadAttribute of `MonitoredNode` to allow custom validation
- Update `ValidateRolePermissions` in `MasterNodeManager.cs` to prevent null reference exception
@romanett romanett added the server label Apr 8, 2025
@romanett romanett requested a review from mrsuciu April 8, 2025 14:10
@romanett romanett self-assigned this Apr 8, 2025
@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.05%. Comparing base (2f0770c) to head (99d3ba5).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
...ies/Opc.Ua.Server/NodeManager/MasterNodeManager.cs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3047      +/-   ##
==========================================
+ Coverage   56.81%   57.05%   +0.23%     
==========================================
  Files         357      357              
  Lines       68862    68978     +116     
  Branches    14133    14160      +27     
==========================================
+ Hits        39123    39354     +231     
+ Misses      25541    25377     -164     
- Partials     4198     4247      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@romanett romanett requested a review from salihgoncu April 8, 2025 14:51
@romanett romanett added this to the 1.5.376 Maintenance Update milestone Apr 21, 2025
Copy link
Contributor

@mrsuciu mrsuciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except the "potential" resource consumption

@romanett romanett requested a review from mrsuciu May 15, 2025 11:53
Copy link
Contributor

@mrsuciu mrsuciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@romanett romanett requested a review from mrsuciu May 15, 2025 17:42
Copy link
Contributor

@mrsuciu mrsuciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NullReferenceException in Opc.Ua.Server.MasterNodeManager.ValidateRolePermissions()

2 participants