-
Notifications
You must be signed in to change notification settings - Fork 1k
[Server] Enhance role permission validation #3047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Make `ValidateRolePermissions` virtual in `CustomNodeManager.cs` to allow custom validation - Initialize OperationContext in Node.ReadAttribute of `MonitoredNode` to allow custom validation - Update `ValidateRolePermissions` in `MasterNodeManager.cs` to prevent null reference exception
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3047 +/- ##
==========================================
+ Coverage 56.81% 57.05% +0.23%
==========================================
Files 357 357
Lines 68862 68978 +116
Branches 14133 14160 +27
==========================================
+ Hits 39123 39354 +231
+ Misses 25541 25377 -164
- Partials 4198 4247 +49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrsuciu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except the "potential" resource consumption
mrsuciu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
mrsuciu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
ValidateRolePermissionsvirtual inCustomNodeManager.csto allow custom validationMonitoredNodeto allow custom validationValidateRolePermissionsinMasterNodeManager.csto prevent null reference exceptionRelated Issues
Types of changes
Checklist