Skip to content

Commit c8a243e

Browse files
authored
Merge pull request #298 from ONSdigital/remove-log-update-templates
Remove log update templates
2 parents 38dd090 + 34dffe6 commit c8a243e

File tree

5 files changed

+12
-35
lines changed

5 files changed

+12
-35
lines changed

.github/ISSUE_TEMPLATE/feature_request.md

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,19 @@ labels: enhancement
66
assignees: ''
77

88
---
9+
It would help the development team for the requester to supply the following information:
910

10-
**Is your feature request related to a problem? Please describe.**
11+
**Is your feature request related to a problem? Please describe:**
1112
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
1213

13-
**Describe the solution you'd like**
14+
**Describe the solution you'd like:**
1415
A clear and concise description of what you want to happen.
1516

16-
**Describe alternatives you've considered**
17+
**Please confirm you've checked our [won't fix](https://github.com/ONSdigital/gptables/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22wontfix%20%3Acry%3A%22) issues**
18+
Yes/no
19+
20+
**Describe alternatives you've considered:**
1721
A clear and concise description of any alternative solutions or features you've considered.
1822

19-
**Additional context**
23+
**Additional context:**
2024
Add any other context or screenshots about the feature request here.

.github/pull_request_template.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
12
### Proposed Changes
23
-
34

@@ -12,6 +13,7 @@ Please indicate items that aren't necessary and why, with comments around incomp
1213
- [ ] Version number has been incremented, according to [SemVer][semver]
1314
- [ ] Changelog has been updated, listing changes to this version. Use the [keep a changelog][changelog] format
1415
- [ ] New features are tested
16+
- [ ] New features follow the Analysis Function Releasing statistics in spreadsheets [guidance][guidance]
1517
- [ ] New features are documented using the [numpydoc][numpy-docstrings] docstring format
1618
- [ ] Other relevant package documentation is updated
1719
- [ ] For new functionality, examples are included in the docs or a [feature request][feature-request] has
@@ -20,5 +22,6 @@ been made for it/them
2022

2123
[changelog]: [https://keepachangelog.com/en/1.0.0/]
2224
[feature-request]: [https://github.com/best-practice-and-impact/gptables/issues/new?assignees=&labels=enhancement&template=feature_request.md&title=]
25+
[guidance]: https://analysisfunction.civilservice.gov.uk/policy-store/releasing-statistics-in-spreadsheets/
2326
[numpy-docstrings]: [https://numpydoc.readthedocs.io/en/latest/format.html]
2427
[semver]: [https://semver.org/spec/v2.0.0.html]

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,4 +135,4 @@ jobs:
135135
run: |
136136
python -m build
137137
- name: Publish
138-
uses: pypa/gh-action-pypi-publish@v1.12.3
138+
uses: pypa/gh-action-pypi-publish@v1.12.3

closed_issue_log.md

Lines changed: 0 additions & 29 deletions
This file was deleted.

docs/info/changelog.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ and this project tries its very best to adhere to
1818
**Added**
1919

2020
* Merged pull request templates to create new one
21-
* Added a ‘closed issue log’
2221
* Requirements and installation steps to README
2322
* Pre-commit hooks
2423

0 commit comments

Comments
 (0)