feat(logger): error.type --> error_type (#134)

* feat(logger): Add fatal_execution_error

* execution error

* don't use period

* fix test

* remove err type

Author: ATMackay

pkg/logger/fields.go

@@ -203,12 +203,12 @@ func WithService(service ServiceFields) Field {
 // WithErrorInfo adds error-related fields to the log entry
 func WithErrorInfo(errFields ErrorFields) []Field {
 	fields := []Field{
-		String("error.type", string(errFields.Type)),
-		String("error.message", errFields.Message),
+		String("error_type", string(errFields.Type)),
+		String("error_message", errFields.Message),
 	}
 
 	if errFields.tracebackSet {
-		fields = append(fields, String("error.traceback", errFields.Traceback))
+		fields = append(fields, String("error_traceback", errFields.Traceback))
 	}
 
 	return fields

pkg/logger/fields_test.go

@@ -98,8 +98,8 @@ func TestLogFields(t *testing.T) {
 					Build()
 			},
 			expected: map[string]interface{}{
-				"error.type":    "agent_error",
-				"error.message": "test error",
+				"error_type":    "agent_error",
+				"error_message": "test error",
 			},
 		},
 		{
@@ -111,9 +111,9 @@ func TestLogFields(t *testing.T) {
 					Build()
 			},
 			expected: map[string]interface{}{
-				"error.type":      "agent_error",
-				"error.message":   "test error",
-				"error.traceback": "test traceback",
+				"error_type":      "agent_error",
+				"error_message":   "test error",
+				"error_traceback": "test traceback",
 			},
 		},
 		{
@@ -147,9 +147,9 @@ func TestLogFields(t *testing.T) {
 					"installation_id": "12345",
 					"owner":           "test-owner",
 				},
-				"error.type":      "agent_error",
-				"error.message":   "test error",
-				"error.traceback": "test traceback",
+				"error_type":      "agent_error",
+				"error_message":   "test error",
+				"error_traceback": "test traceback",
 			},
 		},
 	}