From 6225eb75de54ea23ab01c4684c30b70d1dcc7f44 Mon Sep 17 00:00:00 2001
From: NullVoxPopuli <LPSego3+dev@gmail.com>
Date: Thu, 19 May 2022 21:32:44 -0400
Subject: [PATCH] chore: add floating deps test

---
 .github/workflows/ci.yml                 | 52 +++++++++++++++---------
 build/github-workflows/workflows/ci.yaml | 31 ++++++++------
 2 files changed, 51 insertions(+), 32 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 16f301efd..9d6224a50 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -32,7 +32,7 @@ jobs:
         run: pnpm install
       - name: Build and Assert Output
         run: pnpm --filter ember-resources-build-test test
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v1
         with:
           name: dist
           path: ${{ env.dist }}
@@ -59,7 +59,7 @@ jobs:
       - name: Install Dependencies
         run: pnpm install
       - name: Download built package from cache
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v1
         with:
           name: dist
           path: ${{ env.dist }}
@@ -70,22 +70,14 @@ jobs:
         with:
           path: ./build/estimate-bytes/comment.txt
   tests:
-    name: Base Tests
+    name: Default Tests
     timeout-minutes: 5
     runs-on: ubuntu-latest
     needs:
       - build_test
-    strategy:
-      matrix:
-        node:
-          - "12"
-          - "14"
-          - "16"
     steps:
       - uses: actions/checkout@v3
       - uses: volta-cli/action@v1
-        with:
-          node-version: ${{ matrix.node }}
       - name: Cache pnpm modules
         uses: actions/cache@v3
         with:
@@ -99,14 +91,33 @@ jobs:
       - name: Install Dependencies
         run: pnpm install
       - name: Download built package from cache
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v1
         with:
           name: dist
           path: ${{ env.dist }}
-      - name: Test with ${{ matrix.node }}
-        run: pnpm --filter ember-app run ember:test
+      - run: pnpm --filter ember-app run ember:test
+  floating-deps-tests:
+    name: Floating Deps Test
+    timeout-minutes: 5
+    runs-on: ubuntu-latest
+    needs:
+      - build_test
+    steps:
+      - uses: actions/checkout@v3
+      - uses: volta-cli/action@v1
+      - uses: pnpm/action-setup@v2.2.1
+        with:
+          version: 6.32.1
+      - name: Install Dependencies
+        run: rm pnpm-lock.yaml && pnpm install
+      - name: Download built package from cache
+        uses: actions/download-artifact@v1
+        with:
+          name: dist
+          path: ${{ env.dist }}
+      - run: pnpm --filter ember-app run ember:test
   try-scenarios:
-    name: ${{ matrix.ember-try-scenario }}
+    name: Ember Compatibility
     timeout-minutes: 10
     runs-on: ubuntu-latest
     needs: tests
@@ -142,7 +153,7 @@ jobs:
       - name: Install Dependencies
         run: pnpm install
       - name: Download built package from cache
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v1
         with:
           name: dist
           path: ${{ env.dist }}
@@ -152,7 +163,7 @@ jobs:
           node_modules/.bin/ember try:one ${{ matrix.ember-try-scenario }}
           --skip-cleanup
   typescript-compatibility:
-    name: types w/ ${{ matrix.typescript-scenario }}
+    name: Type checking - ${{ matrix.typescript-scenario }}
     timeout-minutes: 5
     runs-on: ubuntu-latest
     continue-on-error: true
@@ -168,7 +179,7 @@ jobs:
           - typescript@4.6
           - typescript@next
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v2
         with:
           fetch-depth: 1
       - uses: volta-cli/action@v1
@@ -187,7 +198,7 @@ jobs:
       - name: Install Dependencies
         run: pnpm install
       - name: Download built package from cache
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v1
         with:
           name: dist
           path: ${{ env.dist }}
@@ -205,6 +216,7 @@ jobs:
       - tests
       - typescript-compatibility
       - try-scenarios
+      - floating-deps-tests
     steps:
       - uses: actions/checkout@v3
         with:
@@ -223,7 +235,7 @@ jobs:
       - name: Install Dependencies
         run: pnpm install
       - name: Download built package from cache
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v1
         with:
           name: dist
           path: ${{ env.dist }}
diff --git a/build/github-workflows/workflows/ci.yaml b/build/github-workflows/workflows/ci.yaml
index 6c57cd10b..80de7cff4 100644
--- a/build/github-workflows/workflows/ci.yaml
+++ b/build/github-workflows/workflows/ci.yaml
@@ -75,26 +75,33 @@ jobs:
 
 
   tests:
-    name: Base Tests
+    name: Default Tests
     <<: *ubuntu
     needs: ['build_test']
-    strategy:
-      matrix:
-        node:
-          - "12"
-          - "14"
-          - "16"
     steps:
       - uses: actions/checkout@v3
       - uses: volta-cli/action@v1
-        with:
-          node-version: ${{ matrix.node }}
       - *depCache
       - *pnpm
       - *install
       - *getDist
-      - name: Test with ${{ matrix.node }}
-        run: pnpm --filter ember-app run ember:test
+      - run: pnpm --filter ember-app run ember:test
+
+  floating-deps-tests:
+    name: Floating Deps Test
+    <<: *ubuntu
+    needs: ['build_test']
+    steps:
+      - uses: actions/checkout@v3
+      - uses: volta-cli/action@v1
+      # Same as Default tests, but:
+      # - no cache
+      # - "different" install command
+      - *pnpm
+      - name: 'Install Dependencies'
+        run: rm pnpm-lock.yaml && pnpm install
+      - *getDist
+      - run: pnpm --filter ember-app run ember:test
 
   try-scenarios:
     name: "Ember Compatibility"
@@ -172,7 +179,7 @@ jobs:
     name: Release
     <<: *ubuntu
     if: github.ref == 'refs/heads/main' || github.ref == 'refs/heads/master'
-    needs: [tests, typescript-compatibility, try-scenarios]
+    needs: [tests, typescript-compatibility, try-scenarios, floating-deps-tests]
 
     steps:
       - uses: actions/checkout@v3