Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browsing through the source code - possible bug in PackageUtilities? #9724

Open
jhribal opened this issue Jun 27, 2020 · 0 comments
Open

Browsing through the source code - possible bug in PackageUtilities? #9724

jhribal opened this issue Jun 27, 2020 · 0 comments
Labels
Area:ErrorHandling warnings and errors/log messages & related error codes. Category:Quality Week Issues that should be considered for quality week Functionality:SDK The NuGet client packages published to nuget.org good first issue Issues identified as good for first-time contributors hacktoberfest help wanted Considered good issues for community contributions. Priority:2 Issues for the current backlog. Type:Bug

Comments

@jhribal
Copy link

jhribal commented Jun 27, 2020 •
edited
Loading

Hello,
shouldn't be the FatalProtocolException thrown when nuspecStream == null instead of nupkgStream == null?

PackageUtilities.cs

image
@donnie-msft donnie-msft added Type:Engineering product/infrastructure work/not a customer bug/feature/DCR Category:Quality Week Issues that should be considered for quality week Type:Bug Pipeline:Backlog labels Jun 30, 2020
@nkolev92 nkolev92 added Functionality:SDK The NuGet client packages published to nuget.org Area:ErrorHandling warnings and errors/log messages & related error codes. good first issue Issues identified as good for first-time contributors Priority:2 Issues for the current backlog. help wanted Considered good issues for community contributions. hacktoberfest and removed Type:Engineering product/infrastructure work/not a customer bug/feature/DCR labels Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area:ErrorHandling warnings and errors/log messages & related error codes. Category:Quality Week Issues that should be considered for quality week Functionality:SDK The NuGet client packages published to nuget.org good first issue Issues identified as good for first-time contributors hacktoberfest help wanted Considered good issues for community contributions. Priority:2 Issues for the current backlog. Type:Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nkolev92 @jhribal @donnie-msft