Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error NU3001 has 7 scenarios causing maintainability issues #9598

Open
kartheekp-ms opened this issue May 22, 2020 · 0 comments
Open

Error NU3001 has 7 scenarios causing maintainability issues #9598

kartheekp-ms opened this issue May 22, 2020 · 0 comments
Labels
Area:ErrorHandling warnings and errors/log messages & related error codes. Category:Quality Week Issues that should be considered for quality week Functionality:Signing Priority:2 Issues for the current backlog. Type:DCR Design Change Request

Comments

@kartheekp-ms
Copy link
Contributor

NU3001 error code has 7 scenarios where few of them are dependent upon Exception.HResult Property causing maintainability issues.

For e.g. https://github.com/NuGet/NuGet.Client/blob/eb9ad919724e5ef435d6321b775868c9f2c0f9a2/src/NuGet.Core/NuGet.Commands/SignCommand/CertificateProvider.cs#L59-L90

This logic broke tests in package signing logic when dotnet returns a different HRResult value. For e.g. #9523

As per dotnet/runtime#36786 (comment), dotnet doesnot guarantee the HResult values of most of our exceptions, depending on them is going to be fragile..

We need to re-evaluate all the 7 scenarios of NU3001 error code and implement code that doesn't reply on Exception.HRResult if possible.

@kartheekp-ms kartheekp-ms added Area:ErrorHandling warnings and errors/log messages & related error codes. Functionality:Signing labels May 22, 2020
@zkat zkat added the Priority:2 Issues for the current backlog. label Jul 16, 2020
@aortiz-msft aortiz-msft added the Type:DCR Design Change Request label Feb 2, 2022
@nkolev92 nkolev92 added Category:Quality Week Issues that should be considered for quality week and removed Category:Customer Sprint labels Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:ErrorHandling warnings and errors/log messages & related error codes. Category:Quality Week Issues that should be considered for quality week Functionality:Signing Priority:2 Issues for the current backlog. Type:DCR Design Change Request
Projects
None yet
Development

No branches or pull requests

5 participants