Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet restore should log redirects #9590

Open
zivkan opened this issue May 21, 2020 · 0 comments
Open

NuGet restore should log redirects #9590

zivkan opened this issue May 21, 2020 · 0 comments
Labels
Category:Quality Week Issues that should be considered for quality week Functionality:Restore Partner:AzureDevOps Priority:2 Issues for the current backlog. Type:DCR Design Change Request

Comments

@zivkan
Copy link
Member

zivkan commented May 21, 2020

To aid HTTP request error debugging, particularly for teams implementing the NuGet servers, it would be helpful to log the URL that generated the error, when the original request results in an HTTP redirect.

Currently:

Unauthorized https://api.server.test/v3/package/package_id/package_id.1.2.3.nupkg 0ms

Proposed:

Unauthorized https://api.server.test/v3/package/package_id/package_id.1.2.3.nupkg -> https://blobs.server.test/package_id/package_id.1.2.3.nupkg 0ms

Notes:

This longer log line should not happen unless the final response URL is different to the original requested URL. This means that HTTP responses where there is no redirect should remain the same as today's log output.

NuGet should remove secrets from the URL, where possible. If the URL contains HTTP Basic auth, in the form of https://user:pass@server.test/, the user:pass should be stripped from the log. Also consider masking query parameters (not removing, because it's important when debugging to know the parameter was there or not), such as sig(nature)?$|tok(en)?$|ticket$|auth

@aortiz-msft aortiz-msft added Category:Quality Week Issues that should be considered for quality week Priority:2 Issues for the current backlog. labels May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Quality Week Issues that should be considered for quality week Functionality:Restore Partner:AzureDevOps Priority:2 Issues for the current backlog. Type:DCR Design Change Request
Projects
None yet
Development

No branches or pull requests

4 participants