Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TaskStatusCenter instead of IVsStatusBar for restore progress reporting in VS #9396

Open
nkolev92 opened this issue Apr 4, 2020 · 8 comments
Labels
Priority:2 Issues for the current backlog. Product:VS.Client Type:Bug

Comments

@nkolev92
Copy link
Member

nkolev92 commented Apr 4, 2020

This API will work the same in both VS & VS.Oe scenarios.

@nkolev92 nkolev92 self-assigned this Apr 13, 2020
@nkolev92 nkolev92 added this to the Sprint 169 - 2020.04.13 milestone Apr 13, 2020
@nkolev92 nkolev92 changed the title Use TaskStatusCenter instead of IVsStatusBar for VS & VS.Oe Use TaskStatusCenter instead of IVsStatusBar for restore progress reporting in VS & VS.Oe Apr 24, 2020
@nkolev92 nkolev92 added Resolution:BlockedByExternal Progress on this task is blocked by an external issue. When that issue is completed this can proceed and removed Pipeline:Validating labels May 7, 2020
@nkolev92
Copy link
Member Author

nkolev92 commented May 7, 2020

Blocked by: 983811

@nkolev92 nkolev92 removed their assignment May 7, 2020
@nkolev92 nkolev92 removed this from the Sprint 170 - 2020.05.04 milestone May 7, 2020
@nkolev92
Copy link
Member Author

nkolev92 commented May 7, 2020

Moving out of S170 @rrelyea @aortiz-msft @chgill-MSFT

@nkolev92
Copy link
Member Author

Internal issue was closed as not repro. Possible it was fixed by other related efforts since the original filing of the issue.

We should validate that it's actually correct.

@rrelyea rrelyea removed this from the Sprint 179 - 2020.11.09 milestone Jan 11, 2021
@nkolev92 nkolev92 removed the Resolution:BlockedByExternal Progress on this task is blocked by an external issue. When that issue is completed this can proceed label Sep 20, 2021
@nkolev92
Copy link
Member Author

Internal issue fixed again.

@nkolev92 nkolev92 changed the title Use TaskStatusCenter instead of IVsStatusBar for restore progress reporting in VS & VS.Oe Use TaskStatusCenter instead of IVsStatusBar for restore progress reporting in VS Dec 7, 2021
@nkolev92
Copy link
Member Author

We should try not having a task status center for on build and explicit restore, but have one only for solution load.

@zivkan
Copy link
Member

zivkan commented May 13, 2022

Another option is to start the restore, and if it takes more than x time (0.5 seconds? 1 second?) to add the task status center item. That way quick restores don't cause a popup, but longer restores do (whether it's solution load, git branch change, manually editing a csproj).

@nkolev92
Copy link
Member Author

Another option is to start the restore, and if it takes more than x time (0.5 seconds? 1 second?) to add the task status center item.

The API is a bit of a nightmare :D It requires you to pass it a task and it basically tracks completion based on the task returning.

@nkolev92
Copy link
Member Author

Also right now PC and PR restores are completely separate, 2 different progress reportings, so we'd need to combine that somehow, so require some refactoring there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:2 Issues for the current backlog. Product:VS.Client Type:Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants