Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PC -> PR migration dialog incorrectly states 'lib\lib\foo.dll' for 'lib\foo.dll' #7115

Open
Eilon opened this issue Jul 13, 2018 · 2 comments
Labels
Functionality:VisualStudioUI help wanted Considered good issues for community contributions. Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Product:VS.Client Status:Excluded from icebox cleanup Status:Inactive Icebox issues not updated for a specific long time Type:Bug
Milestone

Comments

@Eilon
Copy link

Eilon commented Jul 13, 2018

This happens in default ASP.NET 4.x Web App projects (once you remove the ProjectTypeGuid to enable the migration dialog to show up).

In particular, this happens with the Antlr and WebGrease packages. I verified that at least for WebGrease there is no such lib\lib\ folder:

webgrease.1.6.0\WebGrease.nuspec
webgrease.1.6.0\[Content_Types].xml
webgrease.1.6.0\lib\WebGrease.dll
webgrease.1.6.0\package\services\metadata\core-properties\b4b3ea6284c64b7aa19a4b3f392e6f11.psmdcp
webgrease.1.6.0\tools\WG.EXE
webgrease.1.6.0\_rels\.rels

So, this seems like a UI bug where the lib\ prefix is incorrectly prepended in the warning messages.

cc @rrelyea

@PatoBeltran
Copy link

This issue happens because AnalysisResources.Migrator_AssemblyDirectlyUnderLibWarning referenced here is prepending lib\ to the file path of the assembly, which already has lib\. the fix can be to update the AnalysisResources.Migrator_AssemblyDirectlyUnderLibWarning string or use only the filename here

@PatoBeltran PatoBeltran added Product:VS.Client Type:Bug Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Functionality:VisualStudioUI labels Jul 13, 2018
@PatoBeltran PatoBeltran added this to the Backlog milestone Jul 13, 2018
@PatoBeltran
Copy link

cc @rohit21agrawal

@jainaashish jainaashish added the help wanted Considered good issues for community contributions. label Aug 30, 2018
@ghost ghost added the Status:Inactive Icebox issues not updated for a specific long time label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Functionality:VisualStudioUI help wanted Considered good issues for community contributions. Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Product:VS.Client Status:Excluded from icebox cleanup Status:Inactive Icebox issues not updated for a specific long time Type:Bug
Projects
None yet
Development

No branches or pull requests

6 participants