Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not warn about SemVer 2.0.0 versions when the MinClientVersion is specified beyond 4.3 #6825

Open
Aethon opened this issue Apr 13, 2018 · 2 comments
Open

Do not warn about SemVer 2.0.0 versions when the MinClientVersion is specified beyond 4.3 #6825

Aethon opened this issue Apr 13, 2018 · 2 comments
Labels
Area:ErrorHandling warnings and errors/log messages & related error codes. Functionality:Pack help wanted Considered good issues for community contributions. Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Status:Excluded from icebox cleanup Status:Inactive Icebox issues not updated for a specific long time
Milestone
Backlog

Comments

@Aethon
Copy link

Aethon commented Apr 13, 2018

Please see #4687 for the problem (the problem has not changed).

Now that a package can specify MinClientVersion metadata, this warning should not be presented if the specified client supports SemVer 2.0. This will remove noise from the build and/or allow those that are using SemVer 2.0 versions to take advantage of the package analyzer.
@nkolev92 nkolev92 added Functionality:Pack Area:ErrorHandling warnings and errors/log messages & related error codes. help wanted Considered good issues for community contributions. labels Apr 16, 2018
@nkolev92 nkolev92 added this to the Backlog milestone Apr 16, 2018
@nkolev92 nkolev92 added the Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. label Apr 16, 2018
@nkolev92
Copy link
Member

nkolev92 commented Apr 16, 2018 •
edited
Loading

Thanks for creating this @Aethon
Not sure when we'll get to this because we're prioritizing other work, but we'll gladly take a PR.
//cc @rohit21agrawal

@Aethon
Copy link
Author

Aethon commented Apr 17, 2018

Thanks for the intake. I can't commit to a PR, but I will prolly have a look over the weekend.

@Apollo3zehn Apollo3zehn mentioned this issue Apr 27, 2018
Open
@ghost ghost added the Status:Inactive Icebox issues not updated for a specific long time label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area:ErrorHandling warnings and errors/log messages & related error codes. Functionality:Pack help wanted Considered good issues for community contributions. Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Status:Excluded from icebox cleanup Status:Inactive Icebox issues not updated for a specific long time
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@Aethon @nkolev92 @jeffkl @heng-liu