Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Package Spec redudant APIs #6231

Open
nkolev92 opened this issue Nov 28, 2017 · 2 comments
Open

Clean up Package Spec redudant APIs #6231

nkolev92 opened this issue Nov 28, 2017 · 2 comments
Labels
Category:BreakingChange Functionality:SDK The NuGet client packages published to nuget.org Priority:2 Issues for the current backlog. Type:DCR Design Change Request
Milestone
7.0

Comments

@nkolev92
Copy link
Member

nkolev92 commented Nov 28, 2017 •
edited
Loading

The PackageSpec model currently has a bunch of redundant APIs.

Among those IncludeExcludeFiles, PackOptions, PackInclude etc.

These need to be removed if they are not used anymore.

Likewise a similar analysis needs to be done on rest of the package spec.

Related discussion here

//cc
@emgarten @rohit21agrawal
@nkolev92 nkolev92 added Type:Engineering product/infrastructure work/not a customer bug/feature/DCR Functionality:Restore Functionality:Pack labels Nov 28, 2017
@nkolev92 nkolev92 added this to the Backlog milestone Nov 28, 2017
@nkolev92 nkolev92 mentioned this issue Nov 28, 2017
Merged
@nkolev92 nkolev92 self-assigned this Dec 19, 2018
@nkolev92
Copy link
Member Author

The majority of the removal is done in https://github.com/NuGet/NuGet.Client/tree/dev-nkolev92-cleanupPackageSpecRunTests.

The concern here is that some scenarios would be removed. (Specifically nuget.exe project.json pack).
The flip side is that those scenarios never RTM'd.

@nkolev92 nkolev92 modified the milestones: Backlog, 6.0 Apr 1, 2019
@nkolev92 nkolev92 mentioned this issue Apr 1, 2019
Closed
@nkolev92
Copy link
Member Author

nkolev92 commented Apr 1, 2019

Draft PR in NuGet/NuGet.Client#2784.

@nkolev92 nkolev92 removed the Type:Engineering product/infrastructure work/not a customer bug/feature/DCR label Apr 1, 2019
@nkolev92 nkolev92 added Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Tenet:Performance Performance issues Priority:2 Issues for the current backlog. and removed Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. labels Feb 28, 2020
@nkolev92 nkolev92 removed the Tenet:Performance Performance issues label Jul 3, 2020
@nkolev92 nkolev92 removed this from the 6.0 milestone Aug 27, 2020
@nkolev92 nkolev92 added the Category:Quality Week Issues that should be considered for quality week label Jul 12, 2021
@nkolev92 nkolev92 added this to the Sprint 2021-07 milestone Jul 12, 2021
@nkolev92 nkolev92 removed their assignment Sep 3, 2021
@nkolev92 nkolev92 removed the Category:Quality Week Issues that should be considered for quality week label Sep 3, 2021
@nkolev92 nkolev92 removed this from the Sprint 2021-09 milestone Sep 3, 2021
@aortiz-msft aortiz-msft added the Type:DCR Design Change Request label Feb 2, 2022
@nkolev92 nkolev92 added the TechDebt Technical debt label Dec 1, 2023
@nkolev92 nkolev92 added this to the 7.0 milestone Dec 1, 2023
@nkolev92 nkolev92 added Category:BreakingChange Functionality:SDK The NuGet client packages published to nuget.org and removed Functionality:Pack Functionality:Restore TechDebt Technical debt labels Apr 10, 2024
@nkolev92 nkolev92 mentioned this issue Apr 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category:BreakingChange Functionality:SDK The NuGet client packages published to nuget.org Priority:2 Issues for the current backlog. Type:DCR Design Change Request
Projects
None yet
Milestone
7.0
Development

No branches or pull requests
3 participants
@nkolev92 @heng-liu @aortiz-msft