Package.config project fails to restore if parent directory has directory.build.props with packageref

[clairernovotny]

In VS 2017, I have a solution with SDK style projects and an MVC 4.6 project with packages.config. If I add a directory.build.props file to the parent directory that contains a packageref, restore is incorrect in the mvc/packages.config project.

I would not expect directory.build.props to apply to non-SDK project types.

This happens with 15.2 and 15.3 preview 1

[clairernovotny]

Here's a repro https://github.com/onovotny/NuGetRestoreRepro

[dsplaisted]

Directory.Build.props is a feature of MSBuild 15, and is not specific to SDK-style projects.

Can you move the PackageReference to a Directory.Build.targets file and condition it on whether TargetFramework is set? (With the 2.0 SDK, you will be able to check the UsingMicrosoftNETSdk property instead, and you will be able to do that in the Directory.Build.props file if you like.) That should probably fix the issue.

[clairernovotny]

Is there any default setting for PackageRestoreType that can be checked instead since some projects opt-in to PackageRef by default like UWP. Just seemed like unexpected behavior that would bite people?

[nkolev92]

At this point I believe this issue is a duplicate of #4488.

RestoreProjectStyle is a property that can be used to opt-in projects into PackageReference but it needs officially cleared up in #4488