Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: plumb down install/restore context #5274

Closed
dtivel opened this issue May 23, 2017 · 2 comments
Closed

Plugin: plumb down install/restore context #5274

dtivel opened this issue May 23, 2017 · 2 comments
Assignees
Labels
Area:Plugin V2 plugin w/ cross platform support Icebox cleanup candidate Status:Inactive Icebox issues not updated for a specific long time

Comments

@dtivel
Copy link
Contributor

dtivel commented May 23, 2017

One of the core problems in current plugin design is that the protocol layer (NuGet.Protocol) lacks context on the overall install/restore operation.

  1. Plugin's are not promptly terminated when an operation is complete. Plugins are terminated when either of the following occurseither the NuGet process exits or after some idle time has passed.
  2. Plugin-related resources (in NuGet) are retained after an operation is complete. These resources should be released as soon as the operation is complete.
  3. Faulted plugins are restarted during the same operation. Within an operation, a plugin fault should fail the overall operation.

If some operation context is passed down from NuGet clients to the protocol layer, then the protocol layer can perform necessary cleanup on operation completion.

@dtivel dtivel self-assigned this May 31, 2017
@mishra14 mishra14 added the Area:Plugin V2 plugin w/ cross platform support label Nov 10, 2017
@ghost ghost added the Status:Inactive Icebox issues not updated for a specific long time label Sep 1, 2022
@ghost
Copy link

ghost commented Nov 18, 2022

Due to lack of recent activity, this issue has been marked as a candidate for icebox cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will add a Triage:NeedsTriageDiscussion label and lead to a triaging process.
This process is part of the experimental Stale icebox issues cleanup we are currently trialing. Please share any feedback you might have in the linked issue.

@ghost
Copy link

ghost commented Dec 2, 2022

This issue will now be closed since it had been marked Icebox cleanup candidate, but received no further activity in the past 14 days.

@ghost ghost closed this as completed Dec 2, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Plugin V2 plugin w/ cross platform support Icebox cleanup candidate Status:Inactive Icebox issues not updated for a specific long time
Projects
None yet
Development

No branches or pull requests

4 participants