Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet add package should normalize the version range it writes to csproj #5203

Open
joelverhagen opened this issue May 9, 2017 · 0 comments
Labels
Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Product:dotnet.exe Status:Excluded from icebox cleanup Status:Inactive Icebox issues not updated for a specific long time Style:PackageReference
Milestone

Comments

@joelverhagen
Copy link
Member

dotnet.exe add package newtonsoft.json --version 10.00.1

In the .csproj:

<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>netcoreapp1.1</TargetFramework>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="newtonsoft.json" Version="10.00.1" />
  </ItemGroup>
</Project>

When the same thing is done from PMC in VS, the result is different:

Install-Package newtonsoft.json -Version 10.00.1
<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>netcoreapp1.1</TargetFramework>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="newtonsoft.json" Version="10.0.1" />
  </ItemGroup>
</Project>

We should also consider writing the proper casing of the ID from the installed package.

/cc @mishra14

This is low priority as it is purely aesthetic.

@mishra14 mishra14 self-assigned this May 9, 2017
@mishra14 mishra14 modified the milestone: 4.3 Jun 15, 2017
@mishra14 mishra14 added this to the Future-2 milestone Jun 15, 2017
@mishra14 mishra14 modified the milestones: Future-2, Backlog Oct 18, 2017
@mishra14 mishra14 added the Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. label Oct 18, 2017
@mishra14 mishra14 removed their assignment Aug 13, 2018
@ghost ghost added the Status:Inactive Icebox issues not updated for a specific long time label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Product:dotnet.exe Status:Excluded from icebox cleanup Status:Inactive Icebox issues not updated for a specific long time Style:PackageReference
Projects
None yet
Development

No branches or pull requests

5 participants