dotnet add package command does not provide helpful message if no stable version is available.

[mishra14]

more info: #4918

[mishra14]

This is blocked by the fact that restore does not respond with an error code indicating the type of failure. But once the work at https://github.com/NuGet/Client.Engineering/issues/32 is done (in this sprint or next), we can throw a better error to the user.

[mishra14]

We have improved the restore logging to display a better message -

F:\validation\test> dotnetlocal add package alexa.net
Microsoft (R) Build Engine version 15.2.93.5465
Copyright (C) Microsoft Corporation. All rights reserved.

  Writing C:\Users\anmishr\AppData\Local\Temp\tmpA603.tmp
info : Adding PackageReference for package 'alexa.net' into project 'F:\validation\test\test.csproj'.
log  : Restoring packages for F:\validation\test\test.csproj...
info :   GET https://dev.nugettest.org/api/v2/FindPackagesById()?id='alexa.net'
info :   GET https://dotnetmyget.blob.core.windows.net/artifacts/dotnet-core/nuget/v3/flatcontainer/alexa.net/index.json
info :   GET https://api.nuget.org/v3-flatcontainer/alexa.net/index.json
info :   NotFound https://dotnetmyget.blob.core.windows.net/artifacts/dotnet-core/nuget/v3/flatcontainer/alexa.net/index.json 120ms
info :   GET https://dotnetmyget.blob.core.windows.net/artifacts/dotnet-core/nuget/v3/flatcontainer/system.missing/index.json
info :   GET https://api.nuget.org/v3-flatcontainer/system.missing/index.json
info :   GET https://dev.nugettest.org/api/v2/FindPackagesById()?id='System.Missing'
info :   NotFound https://dotnetmyget.blob.core.windows.net/artifacts/dotnet-core/nuget/v3/flatcontainer/system.missing/index.json 23ms
info :   OK https://api.nuget.org/v3-flatcontainer/alexa.net/index.json 296ms
info :   NotFound https://api.nuget.org/v3-flatcontainer/system.missing/index.json 244ms
info :   OK https://dev.nugettest.org/api/v2/FindPackagesById()?id='alexa.net' 677ms
info :   OK https://dev.nugettest.org/api/v2/FindPackagesById()?id='System.Missing' 3276ms
error: Unable to find a stable package alexa.net with version
error:   - Found 8 version(s) in nuget.org [ Nearest version: 1.0.0-beta-1 ]
error:   - Found 0 version(s) in Microsoft Visual Studio Offline Packages
error:   - Found 0 version(s) in devtest
error:   - Found 0 version(s) in dotnet-core
error: Unable to find package System.Missing. No packages exist with this id in source(s): devtest, dotnet-core, Microsoft Visual Studio Offline Packages, nuget.org
error: Package 'alexa.net' is incompatible with 'all' frameworks in project 'F:\validation\test\test.csproj'.

Once this work is done, we can improve the logs for dotnet add package.

[rrelyea]

@mishra14 - this could be done now?

[mishra14]

Discussed the best course of action offline:

1. Current scenario has improved from when the bug was created because now restore displays a meaningful warning -

error: Unable to find a stable package alexa.net with version
error:   - Found 8 version(s) in nuget.org [ Nearest version: 1.0.0-beta-1 ]
error:   - Found 0 version(s) in Microsoft Visual Studio Offline Packages
error:   - Found 0 version(s) in devtest
error:   - Found 0 version(s) in dotnet-core

2. Next step would be to increase the restore verbosity level to Warning so only warnings and errors are displayed.

3. Last step would be to hide all restore logs from the user and then on restore completion look for warnings and error codes and then wrap around with more meaningful messages in the context of add package command.

[dotnet-policy-service]

Issue is missing Type label, remember to add a Type label