Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonRuntimeFormat writes excessive data #4717

Open
ericstj opened this issue Feb 28, 2017 · 2 comments
Open

JsonRuntimeFormat writes excessive data #4717

ericstj opened this issue Feb 28, 2017 · 2 comments
Labels
Functionality:Restore Functionality:SDK The NuGet client packages published to nuget.org Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Type:Bug

Comments

@ericstj
Copy link

ericstj commented Feb 28, 2017

I was porting some code from an old DNX copy of the RuntimeJson format stuff to use NuGet.RuntimeModel instead and noticed a couple differences.

  • NuGet writes an empty #import array when there aren't any imports.
  • NuGet writes open ended version ranges as [versionMin, ) instead of versionMin

I've worked around both of these to maintain the same file format as before but wanted to make you aware of them.

@emgarten
Copy link
Member

This has been fixed in current builds, I no longer see #import in project.assets.json.

@ericstj
Copy link
Author

ericstj commented May 1, 2019

Looks like this wasn't actually fixed.

@ericstj ericstj reopened this May 1, 2019
@nkolev92 nkolev92 removed this from the 4.5 milestone Feb 4, 2020
@nkolev92 nkolev92 added Functionality:SDK The NuGet client packages published to nuget.org and removed NuGet API labels Apr 24, 2020
@zivkan zivkan added the Priority:2 Issues for the current backlog. label Nov 17, 2020
@zivkan zivkan added the Type:Bug label Apr 6, 2021
@nkolev92 nkolev92 added Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. and removed Priority:2 Issues for the current backlog. labels Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Functionality:Restore Functionality:SDK The NuGet client packages published to nuget.org Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Type:Bug
Projects
None yet
Development

No branches or pull requests

6 participants