Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nuget.exe pack with both -symbols and -suffix give incorrect name to symbol package #3530

Open
joelverhagen opened this issue Sep 26, 2016 · 6 comments
Labels
Functionality:Pack help wanted Considered good issues for community contributions. Priority:2 Issues for the current backlog. Type:Bug
Milestone

Comments

@joelverhagen
Copy link
Member

Steps

  1. Create a .nuspec on disk.
  2. Make sure there are some files to pack (nuget.exe pack won't make an empty package).
  3. Run nuget.exe pack path\to\my.nuspec -symbols -suffix beta

Expected

Two nupkgs, one ending in beta.nupkg and the other ending in beta.symbols.nupkg.

Actual

The symbols package's file name has the version number without the suffix. The .nuspec inside the package seems fine though.

Example

nuget.exe pack VS.Redist.NuGet_VS15.nuspec -symbols -suffix BETA

Attempting to build package from 'VS.Redist.NuGet_VS15.nuspec'.
Successfully created package 'C:\Users\jver\Desktop\foo\VS.Redist.NuGet_VS15.3.5.160923.1438-BETA.nupkg'.
Successfully created package 'C:\Users\jver\Desktop\foo\VS.Redist.NuGet_VS15.3.5.160923.1438-bar.symbols.nupkg'.

Tried on latest dev and 3.5.0-rc1.

@atifaziz
Copy link

I can confirm the same using NuGet 4.3.0.4406. Fortunately, the <version> element in the symbols package does have the suffix so the workaround is just to rename the symbols file and add the suffix manually.

Considering tomorrow is this issue's first anniversary, it would be nice to get an ETA as a gift. 😄

@atifaziz
Copy link

so the workaround is just to rename the symbols file and add the suffix manually.

Another workaround is to use a replacement token, like so:

<version>1.0.0$VersionSuffix$</version>

And then instead of using -Suffix, use -Properties VersionSuffix=-beta1.

@jainaashish jainaashish added Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Type:Bug labels Oct 17, 2017
@jainaashish jainaashish added this to the Backlog milestone Oct 17, 2017
@jainaashish
Copy link
Contributor

This isn't a high priority item for now and besides there are easy workarounds available. So will mark it for upforgrab.

@jainaashish jainaashish added the help wanted Considered good issues for community contributions. label Oct 17, 2017
@ferarias
Copy link

ferarias commented Nov 9, 2017

Ok it's not prioritary since there are workarounds, but it's a malfunction anyway.
Solving using @atifaziz second workaround.

@ferarias
Copy link

ferarias commented Aug 8, 2018

This issue is still active. This is a friendly "bump"

@sharpSteff
Copy link

"bumb"

@aortiz-msft aortiz-msft added Priority:2 Issues for the current backlog. and removed Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. labels Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Functionality:Pack help wanted Considered good issues for community contributions. Priority:2 Issues for the current backlog. Type:Bug
Projects
None yet
Development

No branches or pull requests

9 participants