Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Spec for normalizing validation of settings between nuget.config & VS Options #12557

Open
donnie-msft opened this issue Apr 24, 2023 · 1 comment
Assignees
Labels
Area:Settings NuGet.Config and related issues Functionality:VSOptions Priority:2 Issues for the current backlog. Product:VS.Client Type:Spec

Comments

@donnie-msft
Copy link
Contributor

donnie-msft commented Apr 24, 2023

Create a spec to make progress on #12245

Examples of topics to address:

  • Malformed config
    • Sometimes causes odd behavior when opening VS Options
    • Sometimes quietly ignores the invalid change (eg, `<
  • Inconsistencies between hand-editing and using VS Options to modify settings.
    • VS Options enforces distinct Package Source names (case insensitive)
      typos...
  <packageSourceMapping>
    <clear />
    <paadsfasdfckageSource key="nuget">
      <package pattern="jQuery" />

Pattern pattern (sneaky, looks right, but it's wrong and it's hard to tell in VS that it was ignored

<packageSourceMapping>
    <clear />
    <packageSource key="nuget">
      <pattern pattern="jQuery" />

  • Hand-editing a nuget.config with both "nuget.org" and "NuGet.ORg" is accepted by VS (no errors).

Ideally, we'd have consistent behavior across the board, but the Spec needs to call out any breaking change potential.

/cc @erdembayar

@donnie-msft donnie-msft added Priority:2 Issues for the current backlog. Functionality:VisualStudioUI Area:Settings NuGet.Config and related issues Type:Spec labels Apr 24, 2023
@donnie-msft donnie-msft self-assigned this Apr 24, 2023
@donnie-msft donnie-msft changed the title Create Spec for normalizing validation of nuget.config between CLI & VS Create Spec for normalizing validation of settings between nuget.config & VS Options Apr 24, 2023
@donnie-msft donnie-msft added the Category:Quality Week Issues that should be considered for quality week label May 1, 2023
@donnie-msft donnie-msft removed the Category:Quality Week Issues that should be considered for quality week label Aug 7, 2023
@donnie-msft donnie-msft assigned albarry4 and unassigned donnie-msft Aug 7, 2023
@donnie-msft
Copy link
Contributor Author

@albarry4 in Sprint planning, @aortiz-msft asked me to assign this to you to help define the experience. Thanks!
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1699214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Settings NuGet.Config and related issues Functionality:VSOptions Priority:2 Issues for the current backlog. Product:VS.Client Type:Spec
Projects
None yet
Development

No branches or pull requests

2 participants