Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Bash] Invalid package pattern can be added successfully into the “Package Source Mapping” list #12197

Open
v-luzh opened this issue Oct 27, 2022 · 3 comments
Labels
Area:PackageSourceMapping Issues related to the package source mapping feature Found:ManualTests Functionality:VisualStudioUI Priority:2 Issues for the current backlog. Product:VS.Client Type:DCR Design Change Request

Comments

@v-luzh
Copy link

v-luzh commented Oct 27, 2022

NuGet Product Used

Visual Studio Package Management UI

Product Version

Dev\6.5.0.43

Worked before?

No response

Impact

It bothers me. A fix would be nice

Repro Steps & Context

Details about the problem

VS Version: Main\33026.144
NuGet Version: Dev\6.5.0.43
OS Version: Windows-11-Enterprise-21H2 ENU

Repro Steps:

  1. Open VS, click menu File->New Project, create a Console App (.Net Core) project.
  2. Right-Click the project in the Solution Explorer window and select ‘Manage NuGet Packages…’.
  3. Click the “settings” button on the right panel and click “Package Source Mapping” tab.
  4. Click “Add” button, type invalid string in the package pattern text-box and select a package source in the source list below.
  5. Click “Add” button on the bottom.

Expected:

Invalid package pattern can not be added into the “Package Source Mapping” list.

Actual:

Invalid package pattern can be added successfully into the “Package Source Mapping” list as below.
image

Notes:

It’s not a regression since it is a new feature.

Verbose Logs

No response

@jeffkl
Copy link
Contributor

jeffkl commented Nov 3, 2022

Team Triage: /cc @donnie-msft

@donnie-msft donnie-msft added Type:DCR Design Change Request and removed Type:Bug labels Nov 7, 2022
@donnie-msft
Copy link
Contributor

The behavior is intentional as Validation was not spec'd for the initial release. We may eventually introduce validation here, but until we know more, this input field behaves the same as modifying the config XML manually.

@v-luzh v-luzh changed the title [Bug]: [Bug Bash] Invalid package pattern can be added successfully into the “Package Source Mapping” list [Bug Bash] Invalid package pattern can be added successfully into the “Package Source Mapping” list Jul 13, 2023
@SueSu01
Copy link

SueSu01 commented Aug 23, 2024

It still reproes on VS Main\35222.175 + NuGet Client Dev\6.12.0.82.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:PackageSourceMapping Issues related to the package source mapping feature Found:ManualTests Functionality:VisualStudioUI Priority:2 Issues for the current backlog. Product:VS.Client Type:DCR Design Change Request
Projects
None yet
Development

No branches or pull requests

5 participants