[Bug]: PackageSourceProvider.UpdatePackageSource does not enable a previously disabled source.

[tg73]

NuGet Product Used

NuGet SDK

Product Version

5.10.0

Worked before?

No response

Impact

It's more difficult to complete my work

Repro Steps & Context

In class NuGet.Configuration.PackageSourceProvider, the method:

public void UpdatePackageSource(PackageSource source, bool updateCredentials, bool updateEnabled)

does not apply the configuration changes required when source.IsEnabled is being updated from false to true (when updateEnabled is true, indicating that the update should be applied). I suspect that the problem is here:

disabledSourceItem = disabledSourcesSection?.GetFirstItemWithAttribute<AddItem>(ConfigurationConstants.KeyAttribute, sourceToUpdate.ElementName);

where sourceToUpdate.Key should be used as the last argument. Note that sourceToUpdate.ElementName is always the constant ConfigurationConstants.Add, which does not seem to be what's wanted here.

Verbose Logs

No response

[nkolev92]

Team Triage: Assigning to check whether the PM UI might have the same potential issue.

[nkolev92]

Team Triage: @zivkan we want to know if this is reproable and whether it impacts the product in any way.
The options UI does support enabling a disabled source, so we want to make sure that still works.