[DCR]: Focus shifts from Output window to Error List after every package operation, even with no error or warnings

[chrisraygill]

NuGet Product(s) Affected

Visual Studio Package Management UI

Current Behavior

When I perform any package operation in the PMUI (install, uninstall, update), the Output window flicks open for a moment and then immediately switches focus to the Error List, even when there are no errors or warnings.

See gif:

Desired Behavior

The output window is a good indicator to the user of what's happening:

• Did the operation start?
• Is the operation finished?

If there are no errors or warnings, then the Error List doesn't provide any helpful information.

We should shift focus to the Error List only if there are warnings or errors.

Additional Context

No response

[nkolev92]

It seems like up until 4.7, we were not always bringing the error list to focus.

https://github.com/NuGet/NuGet.Client/blob/5f03bad3794603516c0a1f395f91d056246a1070/src/NuGet.Clients/NuGet.Tools/OutputConsoleLogger.cs#L83-L98

We seemed to have been checking whether there are any error before focusing on the error list.

Note that I have not attempted a repro, so I could be wrong, but it seems like that this change was accidentally made in 4.8

https://github.com/NuGet/NuGet.Client/blame/7269569e7fd88103a15255c0182aa347ddd61f8f/src/NuGet.Clients/NuGet.Tools/OutputConsoleLogger.cs#L71-L82

The change is NuGet/NuGet.Client@f4a1714 which was a fix for #6944.

[nkolev92]

Note for the implementer, please remember to test packages.config, PackageReference SDK and PackageReference csproj projects when working on this.
There are different error list behaviors for all of them.