Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: CPVM - NuGet.exe doesn't include central transitive dependencies in the nuspec of the created package #11647

Closed
marcin-krystianc opened this issue Mar 4, 2022 · 4 comments

Comments

@marcin-krystianc
Copy link

NuGet Product Used

NuGet.exe

Product Version

dev branch

Worked before?

no

Impact

Other

Repro Steps & Context

Not providing detailed repro steps as the NuGet/NuGet.Client#4025 has not been merged yet. It seems that when transitive dependency pinning was implemented originally, support for centralTransitiveDependencyGroups was added to PackTask/dotnet/msbuild but NuGet.exe was missed.

Verbose Logs

No response

@erdembayar
Copy link
Contributor

See description Not providing detailed repro steps as the NuGet/NuGet.Client#4025 has not been merged yet

@marcin-krystianc
Copy link
Author

See description Not providing detailed repro steps as the NuGet/NuGet.Client#4025 has not been merged yet

HI @erdembayar, NuGet/NuGet.Client#4025 is just implementing option to enable a feature called "transitive dependency pinning". But the feature itself was in fact implemented in the past and then was disabled with this PR: NuGet/NuGet.Client#3719.
So it is true that the issue with nuget.exe that I'm reporting here is not yet reproducible, but it will be as soon as NuGet/NuGet.Client#4025 is merged.

@marcin-krystianc
Copy link
Author

I think this issue can be closed. I've just found out, that according to documentation nuget.exe is not supposed to support SDK-style projects, so there is also no reason to expect that it is going to support central transitive dependencies (See https://docs.microsoft.com/en-us/nuget/create-packages/creating-a-package):

  • For non-SDK-style projects, typically .NET Framework projects, follow the steps described in this article to create a package. For step-by-step instructions using Visual Studio and the nuget.exe CLI, see [Create and publish a .NET Framework package (https://docs.microsoft.com/en-us/nuget/quickstart/create-and-publish-a-package-using-visual-studio-net-framework).
  • For .NET Core and .NET Standard projects that use the SDK-style format, and any other SDK-style projects, see Create a NuGet package using the dotnet CLI.

@erdembayar
Copy link
Contributor

As per request above, closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants