Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCR]: Enabled plugins for other protocols #11613

Open
rsking opened this issue Feb 23, 2022 · 3 comments
Open

[DCR]: Enabled plugins for other protocols #11613

rsking opened this issue Feb 23, 2022 · 3 comments
Labels
Area:Plugin V2 plugin w/ cross platform support Priority:2 Issues for the current backlog. Product:dotnet.exe Product:NuGet.exe NuGet.exe Product:VS.Client Type:DCR Design Change Request

Comments

@rsking
Copy link

rsking commented Feb 23, 2022

NuGet Product(s) Affected

NuGet SDK

Current Behavior

Currently plugin discovery is only enabled for HTTP sources.

Desired Behavior

Plugin should be able to support other protocols, or source types.

Additional Context

Plugin discovery is only enabled for HTTP sources

https://github.com/NuGet/NuGet.Client/blob/2ffefa687ba980fd0a70e13615875c69bde9393c/src/NuGet.Core/NuGet.Protocol/Plugins/PluginManager.cs#L122

This should be relaxed to enable other protocols, and it should be up to the plugin to decide whether it can support the protocol.

@rsking rsking added Triage:Untriaged Type:DCR Design Change Request labels Feb 23, 2022
@erdembayar erdembayar added Area:Plugin V2 plugin w/ cross platform support and removed Triage:Untriaged labels Mar 1, 2022
@erdembayar
Copy link
Contributor

erdembayar commented Mar 1, 2022

@rsking
Could you tell us more? What other protocols and sources would you like supported?
What would be benefits and use cases for added protocol and sources?

@rsking
Copy link
Author

rsking commented Mar 1, 2022

My specific use case is for using an authenticated S3 bucket as a source. They are generally given a URL like s3://bucketname/path. I have written a custom provider that can take this as URL, and then get the packages from the source, but this cannot be used as a plugin, as a plugin can only be HTTP(s).

@erdembayar
Copy link
Contributor

erdembayar commented Mar 1, 2022

But it still using HTTP(s) protocol, right? Do you have sample project repo code, wiki help us understand more?

@erdembayar erdembayar added the WaitingForCustomer Applied when a NuGet triage person needs more info from the OP label Mar 1, 2022
@nkolev92 nkolev92 added Priority:2 Issues for the current backlog. and removed WaitingForCustomer Applied when a NuGet triage person needs more info from the OP labels Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Plugin V2 plugin w/ cross platform support Priority:2 Issues for the current backlog. Product:dotnet.exe Product:NuGet.exe NuGet.exe Product:VS.Client Type:DCR Design Change Request
Projects
None yet
Development

No branches or pull requests

4 participants