Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCR]: NuGet VS extensibility packages should suppress themselves from customer vsix #11507

Open
zivkan opened this issue Jan 13, 2022 · 0 comments
Assignees
Labels
Category:Quality Week Issues that should be considered for quality week Functionality:SDK The NuGet client packages published to nuget.org Priority:2 Issues for the current backlog. Product:VS.Client Type:DCR Design Change Request

Comments

@zivkan
Copy link
Member

zivkan commented Jan 13, 2022

NuGet Product(s) Affected

NuGet SDK

Current Behavior

If you create a VSIX project in VSIX, and build it, notice that none of the VS SDK assemblies are in the bin folder or in the vsix itself.

Now add a PackageReference to NuGet.VisualStudio and/or NuGet.VisualStudio.Contracts and build again. Now NuGet's assemblies are both in the bin folder and the vsix

Desired Behavior

Since NuGet.VisualStudio.dll and NuGet.VisualStudio.Contracts.dll have binding redirects and CodeBase in devenv.exe.config, plus the customer's extension would break if their extension used the copy from their own folder instead of the one NuGet itself uses. Hence these assemblies should not be included in the vsix.

Additional Context

The VS SDK appears to use an MSBuild item <SuppressFromVsix Include="nameof.dll" />

@zivkan zivkan added Product:VS.Client Functionality:SDK The NuGet client packages published to nuget.org Type:DCR Design Change Request Category:Quality Week Issues that should be considered for quality week labels Jan 13, 2022
@zivkan zivkan added this to the Sprint 2022-01 milestone Jan 13, 2022
@zivkan zivkan self-assigned this Jan 13, 2022
@zivkan zivkan modified the milestones: Sprint 2022-01, Sprint 2022-02 Feb 7, 2022
@zivkan zivkan removed this from the Sprint 2022-03 milestone Mar 7, 2022
@nkolev92 nkolev92 added the Priority:2 Issues for the current backlog. label Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Quality Week Issues that should be considered for quality week Functionality:SDK The NuGet client packages published to nuget.org Priority:2 Issues for the current backlog. Product:VS.Client Type:DCR Design Change Request
Projects
None yet
Development

No branches or pull requests

3 participants