Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: PMC source dropdown selection doesn't show correctly for sources with special characters such as "encyclopædia" to be selected #11235

Open
erdembayar opened this issue Sep 16, 2021 · 9 comments
Labels
Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Product:VS.PMConsole Triage:NeedsMoreInfo Type:Bug

Comments

@erdembayar
Copy link
Contributor

erdembayar commented Sep 16, 2021

NuGet Product Used

Visual Studio Package Manager Console

Product Version

n/a

Worked before?

n/a

Impact

It bothers me. A fix would be nice

Repro Steps & Context

Follow up on comment
PMC doesn't show difference between encyclopaedia on encyclopædia on when selecting sources, but it does list both versions.

1

Verbose Logs

No response

@chrisraygill
Copy link
Contributor

Hi Erick! Can you add a title to this issue to make it more clear what it's addressing?

@erdembayar erdembayar changed the title [Bug]: [Bug]: PMC doesn't show correct source name correctly for "encyclopædia" Sep 20, 2021
@erdembayar erdembayar changed the title [Bug]: PMC doesn't show correct source name correctly for "encyclopædia" [Bug]: PMC doesn't show source name correctly for "encyclopædia" Sep 20, 2021
@erdembayar
Copy link
Contributor Author

Hi Erick! Can you add a title to this issue to make it more clear what it's addressing?

Please check now.

@nkolev92
Copy link
Member

It seems to me that the difference is shown in the drop down, but selection doesn't work?

Is that right?

Correcting the title accordingly.

@nkolev92 nkolev92 changed the title [Bug]: PMC doesn't show source name correctly for "encyclopædia" [Bug]: PMC source dropdown does not allow for sources with special characters such as "encyclopædia" to be selected Sep 21, 2021
@nkolev92
Copy link
Member

@erdembayar
Can you please confirm my changes are correct?

@nkolev92
Copy link
Member

Given that this is not a regression, and customers have not filled related issues, I'm gonna push this to the icebox.

@nkolev92 nkolev92 added Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Pipeline:Icebox and removed Triage:Untriaged labels Sep 21, 2021
@erdembayar erdembayar changed the title [Bug]: PMC source dropdown does not allow for sources with special characters such as "encyclopædia" to be selected [Bug]: PMC source dropdown selection doesn't show correctly for sources with special characters such as "encyclopædia" to be selected Sep 21, 2021
@erdembayar
Copy link
Contributor Author

erdembayar commented Sep 21, 2021

@erdembayar
Can you please confirm my changes are correct?

Ok. Corrected. Your changes are correct.

@erdembayar erdembayar changed the title [Bug]: PMC source dropdown selection doesn't show correctly for sources with special characters such as "encyclopædia" to be selected [Bug]: PMC source dropdown selection doesn't show correctly for sources with special characters such as "encyclopædia" Sep 21, 2021
@erdembayar erdembayar changed the title [Bug]: PMC source dropdown selection doesn't show correctly for sources with special characters such as "encyclopædia" [Bug]: PMC source dropdown selection doesn't show correctly for sources with special characters such as "encyclopædia" to be selected Sep 21, 2021
@nkolev92
Copy link
Member

I'm not sure what doesn't show correctly means here.

Show where?
The dropdown shows the encyclopædia in the gif.

@erdembayar
Copy link
Contributor Author

I'm not sure what doesn't show correctly means here.

Show where?
The dropdown shows the encyclopædia in the gif.

After selecting encyclopædia from drop down it still show encyclopaedia on selection.

@nkolev92
Copy link
Member

Doesn't, does not select better describe the problem? It seems convoluted as written.

Anyway, I had trouble reproing. Is this a reliable repro for you?

See attached gif. The sources behind are nuget-build and nuget-org.

PMC-FindPackage

Is it possible that both sources had the same url in your case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Product:VS.PMConsole Triage:NeedsMoreInfo Type:Bug
Projects
None yet
Development

No branches or pull requests

4 participants