Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ArgumentException to CommandException for PackagePath argument #10391

Open
donnie-msft opened this issue Dec 17, 2020 · 0 comments
Open

Change ArgumentException to CommandException for PackagePath argument #10391

donnie-msft opened this issue Dec 17, 2020 · 0 comments
Labels
Area:Logging Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Product:dotnet.exe Product:NuGet.exe NuGet.exe Type:Bug

Comments

@donnie-msft
Copy link
Contributor

In a PR review comment, @kartheekp-ms suggested switching from ArgumentException/ArgumentNullException to CommandException here. I think that makes sense.

/cc @dominoFire to see if you agree with the following...
NuGet/NuGet.Client#3799 (comment)

I think this case falls under CommandException as PackagePath is an argument to nuget verify command. Inspired from below code.

Code: https://github.com/NuGet/NuGet.Client/blob/a52c0addf437f4e358f786acadd4c91a2c80f9b6/src/NuGet.Clients/NuGet.CommandLine/Commands/AddCommand.cs#L31-L35
@donnie-msft donnie-msft mentioned this issue Dec 17, 2020
Merged
@nkolev92 nkolev92 added the Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area:Logging Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Product:dotnet.exe Product:NuGet.exe NuGet.exe Type:Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nkolev92 @heng-liu @donnie-msft