Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS: logging should indicate target project in start of package operation #10209

Open
dtivel opened this issue Oct 30, 2020 · 0 comments
Open
Labels
Area:Logging Functionality:Install The install command in VS/nuget.exe Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog.

Comments

@dtivel
Copy link
Contributor

dtivel commented Oct 30, 2020

Installing a package to a solution (like NuGet.Client) yields output similar to the following partial output in the Package Manager output window pane:

...
Installing NuGet package System.Ben 1.0.1.
Committing restore...
Writing assets file to disk. Path: E:\git\NuGet.Client.Test\artifacts\NuGet.Versioning\16.0\obj\project.assets.json
Successfully installed 'System.Ben 1.0.1' to NuGet.Versioning
Executing nuget actions took 3.51 sec
Installing NuGet package System.Ben 1.0.1.
Committing restore...
Writing assets file to disk. Path: E:\git\NuGet.Client.Test\artifacts\NuGet.Frameworks\16.0\obj\project.assets.json
Successfully installed 'System.Ben 1.0.1' to NuGet.Frameworks
Executing nuget actions took 1.94 sec
...

While the end of installation indicates the target project:

Successfully installed 'System.Ben 1.0.1' to NuGet.Versioning

...the start of installation does not.

This log line:

Installing NuGet package System.Ben 1.0.1.

...would be improved if it mentioned the target project (or assets file):

Installing NuGet package System.Ben 1.0.1 to NuGet.Versioning.

While I write this, I also notice some inconsistencies:

  • In the "Installing ..." message, the package identity is not surrounded with single quotation marks.
  • In the "Successfully installed ..." message, the package identity is surrounded with single quotation marks.
  • In the 'Executing ..." message, "nuget" is not properly capitalized like it is in other log messages around it.
@zkat zkat added Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Functionality:Install The install command in VS/nuget.exe labels Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Logging Functionality:Install The install command in VS/nuget.exe Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog.
Projects
None yet
Development

No branches or pull requests

4 participants