Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM UI: improve perf of PackageSolutionDetailControlModel.GetConstraintsForSelectedProjectsAsync(...) #10094

Open
dtivel opened this issue Sep 30, 2020 · 0 comments
Labels

Comments

@dtivel
Copy link
Contributor

dtivel commented Sep 30, 2020

PackageSolutionDetailControlModel.CreateVersionsAsync(...) fetches project metadata for each selected project one at a time --- twice! here and here.

When 1 project is selected, the potential for performance improvement is minimal. However, when many projects are selected the potential for improvement is great, especially in VS OE scenarios where project metadata retrieval is over the network.

At a minimum, the results of one retrieval should be reused. Ideally, project metadata retrieval can be completely avoided if ProjectVersionConstraint.ProjectName is changed to ProjectVersionConstraint.ProjectId.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants