Skip to content

Merge stable head and body into one table #2860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 26, 2025
Merged

Merge stable head and body into one table #2860

merged 2 commits into from
Jan 26, 2025

Conversation

@jevenski
Copy link
Contributor

@jevenski jevenski commented Jan 21, 2025

  • Merge stable-head and stable-body into one HTML table, and thus removes the process to sync horizontal scroll position.
  • Fix table header split away from table body when scrolled to right end (Torrent table row header not always aligned with column #2794).
  • Adjust internal styles of the s-table to fit the new table structure.

Fixes: #2794

@jevenski
Merge stable head and body into one table
26a1fd4 
- Merge stable-head and stable-body into one HTML table, and thus
  removes the process to sync horizontal scroll position.
- Fix table header split away from table body when scrolled to right
  end (Novik#2794).
- Adjust internal styles of the s-table to fit the new table structure.
@koblack
Copy link
Contributor

koblack commented Jan 24, 2025

Can't sort table on mobile device. When I tap on header nothing happens.
Tested on jevenski/merge-stable branch with chrome/andoroid.

On desktop chrome/windows everything seems to work fine.

@jevenski
Copy link
Contributor Author

jevenski commented Jan 26, 2025 •
edited
Loading

Alright... This patch is still buggy with other header dragging issues. Needs a little more tuning.

Edit: various bugs fixed, including #2849

@jevenski
Fix various bugs
792a198 
- Fix move header display postion error.
- Fix table sorting on mobile screens.
- Fix tracker icon display issue
  (Novik#2849).
@koblack
Copy link
Contributor

koblack commented Jan 26, 2025

Thanks for the quick fix, everything seems to be fine now.

This was linked to issues Jan 26, 2025
[develop] tracker favicons not displaying correctly #2849
Closed
Torrent table row header not always aligned with column #2794
Closed
@stickz stickz merged commit 8eb76bc into Novik:develop Jan 26, 2025
@jevenski jevenski deleted the merge-stable branch January 26, 2025 23:25
stickz added a commit to stickz/docker-rtorrent-rutorrent that referenced this pull request Apr 27, 2025
@stickz
ruTorrent: Upgrade to v5.2.1
9a8a526 
**Full Changelog**: Novik/ruTorrent@v5.1.7...v5.2.1

# ruTorrent v5.2.1
This is a critical hotfix to resolve breakage of RSS feeds. It's highly recommended to upgrade.
In addition, the white border is fixed on dark themes. A stopped state is also added to torrents.

## What's Changed
* Adding Stopped state by ranirahn in Novik/ruTorrent#2893
* Fix for broken RSS feeds break the rutorrent. by ranirahn in Novik/ruTorrent#2894
* Fix white border in dark themes by drrako in Novik/ruTorrent#2898

**Full Changelog**: Novik/ruTorrent@v5.2.0...v5.2.1

# ruTorrent v5.2.0 is now Stable
This is a release contains more mobile design improvements, performance improvements and various new features. It builds on progress made in ruTorrent `v5.1` toward mobile development. 

## Critical Improvement Summary

1. Torrents now have bigger font to make them easier to read.
2. There is no more drag mask when moving around dialog boxes.
3. Internet explorer is no longer supported. (Yes finally, we dropped it)
4. Various performance improvements to tables to improve responsiveness.
5. The clear log now has a bootstrap button in the bottom right corner.
6. Many other smaller improvements, bug fixes and new features.

## What's Changed
* Fix torrent deleted without confirmation by koblack in Novik/ruTorrent#2804
* filedrop plugin: support dropped links by pekman in Novik/ruTorrent#2806
* Remove drag mask object by jevenski in Novik/ruTorrent#2805
* Covert clear log to a floating button by jevenski in Novik/ruTorrent#2810
* Use bootstrap dropdown on recent trackers by jevenski in Novik/ruTorrent#2809
* Use flex layout on context menu items by jevenski in Novik/ruTorrent#2812
* Adjust status bar and top menu by jevenski in Novik/ruTorrent#2813
* Define dialog window colors using variables by jevenski in Novik/ruTorrent#2815
* Distribute WebUi space using flex layout by jevenski in Novik/ruTorrent#2826
* Remove Internet Explorer support, and some useragent sniffing hacks by anthonyryan1 in Novik/ruTorrent#2825
* Change various s-table methods by jevenski in Novik/ruTorrent#2821
* Define status bar icons using base64 strings by jevenski in Novik/ruTorrent#2833
* Animate category panel by jevenski in Novik/ruTorrent#2831
* Define getter functions on s-table by jevenski in Novik/ruTorrent#2830
* Use bootstrap list group on options window by jevenski in Novik/ruTorrent#2819
* Define s-table header styles using variables by jevenski in Novik/ruTorrent#2836
* Improve s-table column resizing by jevenski in Novik/ruTorrent#2837
* Control alternate row color using CSS by jevenski in Novik/ruTorrent#2841
* Improve move column function by jevenski in Novik/ruTorrent#2844
* Improve s-table header row hover event handler by jevenski in Novik/ruTorrent#2851
* Drag and drop s-table header using DnD class by jevenski in Novik/ruTorrent#2855
* Merge stable head and body into one table by jevenski in Novik/ruTorrent#2860
* Add danger color to #randomize_hash by anthonyryan1 in Novik/ruTorrent#2875
* Fix various bugs for v5.2 by jevenski in Novik/ruTorrent#2863
* Let rutracker_check ignore torrents with certain labels by drrako in Novik/ruTorrent#2866
* Add "::1" to localhost address list. by rozhuk-im in Novik/ruTorrent#2881
* Improve $tempDirectory handling: by rozhuk-im in Novik/ruTorrent#2880
* Diskspace option to display free bytes (new pull request against develop branch) by TheGoblinHero in Novik/ruTorrent#2890
* Add a permission to hide all torrent options by fffe in Novik/ruTorrent#2868
* Mark ruTorrent v5.2 as Stable by stickz in Novik/ruTorrent#2891

## New Contributors
* pekman made their first contribution in Novik/ruTorrent#2806
* rozhuk-im made their first contribution in Novik/ruTorrent#2881

**Full Changelog**: Novik/ruTorrent@v5.1.7...v5.2.0
@stickz stickz mentioned this pull request Apr 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug cleanup v5.2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[develop] tracker favicons not displaying correctly Torrent table row header not always aligned with column

3 participants

@jevenski @koblack @stickz