Don't assume serialport.isOpen is a function (for forwards compatibility) #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencefr
reviewed
Jan 15, 2018
actions/rssiActions.js
Outdated
| export function close() { | ||
| return dispatch => { | ||
| if (port && port.isOpen()) { | ||
| if (port && port.isOpen && (typeof (port.isOpen) !== 'function' || port.isOpen())) { |
Contributor
There was a problem hiding this comment.
Though correct, it's not grouped logically. I'd suggest a condition that doesn't make you stop reading:
port && (typeof (port.isOpen) === 'function' ? port.isOpen() : port.isOpen)
bencefr
previously approved these changes
Jan 15, 2018
mrodem
approved these changes
Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
serialportv4,port.isOpenis afunction; but this behaviour changed in v5, where it's aboolean. See serialport/node-serialport#899My local build is running
serialportv6 due to NordicSemiconductor/pc-nrfconnect-launcher#155, and we might decide to go ahead with updatingserialportaround. Hence this pull req.