Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump version to v0.8.4 #581

Merged
merged 9 commits into from
Jun 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 5 additions & 16 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
on:
push:
branches:
- main
- "*"
pull_request:
branches:
- "*"
workflow_dispatch:


jobs:
build:
Expand All @@ -24,30 +23,20 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: "18.x"

- name: npm latest
run: npm i -g npm@8 && npm i -g npm@latest
node-version: "latest"

- name: Cache Node Modules
id: cache-node-modules
uses: actions/cache@v3
env:
cache-name: cache-node-modules
with:
path: |
node_modules
client/node_modules
server/node_modules
coc/node_modules
test/e2e/node_modules
test/protocol/node_modules
test/protocol/projects/hardhat/node_modules
key: ${{ runner.os }}-node-modules-${{ hashFiles('**/package-lock.json') }}
path: "**/node_modules"
key: ${{ runner.os }}-node-modules-${{ hashFiles('**/package.json', '**/package-lock.json') }}

- name: Install dependencies
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: npm install
run: npm ci

- name: Lint
run: npm run lint
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/review-requested-slack-notification.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
name: PR review requested Slack notification
on:
pull_request_target:
types: [review_requested]
jobs:
requested:
uses: NomicFoundation/github-actions-workflows/.github/workflows/review-requested-slack-notification.yml@main
secrets: inherit
8 changes: 8 additions & 0 deletions .github/workflows/review-submitted-slack-notification.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
name: PR reviewed Slack notification
on:
pull_request_review:
types: [submitted]
jobs:
reviewed:
uses: NomicFoundation/github-actions-workflows/.github/workflows/review-submitted-slack-notification.yml@main
secrets: inherit
7 changes: 7 additions & 0 deletions client/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@ All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

## 0.8.4 - 2024-06-24

### Added

- add markdown syntax support ([575](https://github.com/NomicFoundation/hardhat-vscode/pull/575))
- Bump Slang to 0.15.1 ([578](https://github.com/NomicFoundation/hardhat-vscode/pull/578))

## 0.8.3 - 2024-05-08

### Added
Expand Down
16 changes: 15 additions & 1 deletion client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"displayName": "Solidity",
"description": "Solidity and Hardhat support by the Hardhat team",
"license": "MIT",
"version": "0.8.3",
"version": "0.8.4",
"private": true,
"main": "./out/extension.js",
"module": "./out/extension.js",
Expand Down Expand Up @@ -115,13 +115,27 @@
".sol"
],
"configuration": "./language-configuration.json"
},
{
"id": "solidity-markdown-injection"
}
],
"grammars": [
{
"language": "solidity",
"scopeName": "source.solidity",
"path": "./syntaxes/solidity.json"
},
{
"language": "solidity-markdown-injection",
"scopeName": "markdown.solidity.codeblock",
"path": "./syntaxes/solidity-markdown-injection.json",
"injectTo": [
"text.html.markdown"
],
"embeddedLanguages": {
"meta.embedded.block.solidity": "solidity"
}
}
],
"snippets": [
Expand Down
45 changes: 45 additions & 0 deletions client/syntaxes/solidity-markdown-injection.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
{
"fileTypes": [],
"injectionSelector": "L:text.html.markdown",
"patterns": [
{
"include": "#solidity-code-block"
}
],
"repository": {
"solidity-code-block": {
"begin": "(^|\\G)(\\s*)(\\`{3,}|~{3,})\\s*(?i:(solidity)(\\s+[^`~]*)?$)",
"name": "markup.fenced_code.block.markdown",
"end": "(^|\\G)(\\2|\\s{0,3})(\\3)\\s*$",
"beginCaptures": {
"3": {
"name": "punctuation.definition.markdown"
},
"4": {
"name": "fenced_code.block.language.markdown"
},
"5": {
"name": "fenced_code.block.language.attributes.markdown"
}
},
"endCaptures": {
"3": {
"name": "punctuation.definition.markdown"
}
},
"patterns": [
{
"begin": "(^|\\G)(\\s*)(.*)",
"while": "(^|\\G)(?!\\s*([`~]{3,})\\s*$)",
"contentName": "meta.embedded.block.solidity",
"patterns": [
{
"include": "source.solidity"
}
]
}
]
}
},
"scopeName": "markdown.solidity.codeblock"
}
4 changes: 0 additions & 4 deletions client/syntaxes/solidity.json
Original file line number Diff line number Diff line change
Expand Up @@ -147,10 +147,6 @@
"match": "(@custom:[a-z]+(-[a-z]+)*)\\b",
"name": "storage.type.custom.natspec"
},
"natspec-tag-custom": {
"match": "(@custom:[a-z]+(-[a-z]+)*)\\b",
"name": "storage.type.custom.natspec"
},
"comment": {
"patterns": [
{
Expand Down
4 changes: 2 additions & 2 deletions coc/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "@nomicfoundation/coc-solidity",
"description": "Solidity and Hardhat support for coc.nvim",
"license": "MIT",
"version": "0.8.3",
"version": "0.8.4",
"author": "Nomic Foundation",
"repository": {
"type": "git",
Expand All @@ -29,7 +29,7 @@
"clean": "rimraf out .nyc_output coverage *.tsbuildinfo *.log"
},
"dependencies": {
"@nomicfoundation/solidity-language-server": "0.8.3"
"@nomicfoundation/solidity-language-server": "0.8.4"
},
"devDependencies": {
"coc.nvim": "^0.0.80",
Expand Down
28 changes: 15 additions & 13 deletions docs/publish-extension.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,24 +31,26 @@ release.
```

9. Push the release branch and open a pull request using the new changelog entry as the PR description
10. Generate a release candidate vsix file with `npm run package`, the vsix file should appear in the `./client` folder with the new version number

> WARNING: ensure .env file is populated with GA and Sentry secrets before packaging (see `./env.example`)
10. Ensure .env file is populated with GA and Sentry secrets before packaging (see `./env.example`)

11. Manually run smoke tests on the new features across:
11. Generate a release candidate vsix file with `npm run package`, the vsix file should appear in the `./client` folder with the new version number

12. Manually run smoke tests on the new features across:

- mac os x
- windows
- vscode running against docker

12. On a successful check, `rebase merge` the release branch into main
13. Switch to main branch and pull the latest changes
14. Git tag the version, `g tag -a v0.x.x -m "v0.x.x"` and push the tag `git push --follow-tags`
15. Publish the language server npm package, `cd ./server && npm publish`
16. Publish the coc extension, `cd ./coc && npm publish --non-interactive`
17. Upload the vsix file to the microsoft marketplace: `npx vsce publish -p $VSCE_TOKEN --packagePath client/hardhat-solidity-0.X.X.vsix`
18. Upload the vsix file to openvsx, `npx ovsx publish client/hardhat-solidity-0.X.X.vsix -p $OVSX_TOKEN`
19. Create a release on github off of the pushed tag
13. Ensure that metrics are reported correctly in both Google Analytics and Sentry for the new version.
14. On a successful check, `rebase merge` the release branch into main
15. Switch to main branch and pull the latest changes
16. Git tag the version, `git tag -a v0.x.x -m "v0.x.x"` and push the tag `git push --follow-tags`
17. Publish the language server npm package, `cd ./server && npm publish`
18. Publish the coc extension, `cd ./coc && npm publish --non-interactive`
19. Upload the vsix file to the microsoft marketplace: `npx vsce publish -p $VSCE_TOKEN --packagePath client/hardhat-solidity-0.X.X.vsix`
20. Upload the vsix file to openvsx, `npx ovsx publish client/hardhat-solidity-0.X.X.vsix -p $OVSX_TOKEN`
21. Create a release on github off of the pushed tag

- use the added changelog section as the body of the release
- append the Nomic is Hiring section to the end of the release not:
Expand All @@ -61,8 +63,8 @@ release.

- upload the vsix file as an asset

18. Rebase `development` onto `main`, and force push back to github
19. Update the discord announcements channel
22. Rebase `development` onto `main`, and force push back to github
23. Update the discord announcements channel

- link to the release entry on github (i.e. `https://github.com/NomicFoundation/hardhat-vscode/releases/tag/v0.x.x`)
- give a few sentences of description of why users should be excited about this release
4 changes: 2 additions & 2 deletions flags.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"documentSymbol": {
"percent": 0.05
"percent": 0
},

"semanticHighlighting": {
"percent": 0.05
"percent": 0
}
}
Loading
Loading