Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add forge fmt option #239

Merged
merged 2 commits into from
Sep 9, 2022
Merged

feat: add forge fmt option #239

merged 2 commits into from
Sep 9, 2022

Conversation

fubhy
Copy link
Contributor

@fubhy fubhy commented Aug 20, 2022

Adapting juanfranblanco/vscode-solidity#359 to work with this extension too (h/t @shekhirin)

@kanej kanej added the type:improvement Improvement existing feature label Aug 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2022

Codecov Report

Merging #239 (0fcc25f) into development (2bcb7b2) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development     #239   +/-   ##
============================================
  Coverage        70.68%   70.68%           
============================================
  Files              169      169           
  Lines             4073     4073           
  Branches           711      711           
============================================
  Hits              2879     2879           
  Misses             968      968           
  Partials           226      226           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kanej kanej changed the base branch from main to development August 23, 2022 11:03
Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great.

Reading from in-memory is the only block.

We are currently working on better integration tests, and this will be a good excuse to improve our formatting tests. But we will handle that in a later PR.

I am really excited to get some foundry support in. Thanks!

client/src/formatter/forgeFormatter.ts Outdated Show resolved Hide resolved
Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been able to test the new forge fmt option on windows.

@kanej kanej merged commit b5daf0f into NomicFoundation:development Sep 9, 2022
@antico5 antico5 mentioned this pull request Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:improvement Improvement existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants