Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce coc-solidity deps #373

Closed
kanej opened this issue Jan 17, 2023 · 0 comments · Fixed by #382
Closed

Reduce coc-solidity deps #373

kanej opened this issue Jan 17, 2023 · 0 comments · Fixed by #382
Labels
status:ready This issue is ready to be worked on type:improvement Improvement existing feature
Milestone
Standalone langua...

Comments

@kanej
Copy link
Member

kanej commented Jan 17, 2023

The install time for coc-solidity is high (27s). We suspect this is npm pulling in all the deps.

We should consider switching the language server to a dev dependency, as we bundle it avoiding downloading it twice.
@kanej kanej added type:improvement Improvement existing feature status:ready This issue is ready to be worked on and removed status:triaging labels Jan 17, 2023
@kanej kanej moved this to Todo in hardhat-vscode Jan 17, 2023
@kanej kanej added this to the Standalone language server milestone Jan 17, 2023
@antico5 antico5 mentioned this issue Jan 24, 2023
Merged
@antico5 antico5 moved this from Todo to In Progress in hardhat-vscode Jan 25, 2023
@kanej kanej moved this from In Progress to In Review in hardhat-vscode Feb 7, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in hardhat-vscode Feb 7, 2023
This was referenced Feb 17, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:ready This issue is ready to be worked on type:improvement Improvement existing feature
Projects
hardhat-vscode
Status: Done
Milestone
Standalone language server
Development

Successfully merging a pull request may close this issue.

chore: reduce server dependencies NomicFoundation/hardhat-vscode
1 participant
@kanej