Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the example in readme to prevent "location" field displays wrong way when running as script with Node.js. (nested displayed as [Array]) #185

Merged
merged 2 commits into from
Dec 17, 2023

Conversation

zxkmm
Copy link
Contributor

@zxkmm zxkmm commented Dec 17, 2023

this PR fix the example in readme to prevent "location" field displays wrong way when running as script with Node.js. (nested displayed as [Array])
Since this repo doesn't have a "dev" branch and i don't have permission to this repo to push more branches, this PR directly pointed to master/main branch. If i need to change it, feel free to ask me to do so.
Thx

README.md Outdated Show resolved Hide resolved
@fraxken
Copy link
Member

fraxken commented Dec 17, 2023

Thanks for opening a PR,

Not sure why adding a new example? We just need to update the one above no?

@zxkmm
Copy link
Contributor Author

zxkmm commented Dec 17, 2023

Thank you so much for the approval. :)


We just need to update the one above no?

I originally thought better to keep users have choices. But later @PierreDemailly nicely provided a nice usage I didn't know before. Which works better. thx! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants