Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ImportExpression. #259

Closed
jean-michelet opened this issue Apr 20, 2024 · 1 comment · Fixed by #261
Closed

Add support for ImportExpression. #259

jean-michelet opened this issue Apr 20, 2024 · 1 comment · Fixed by #261

Comments

@jean-michelet
Copy link
Contributor

Currently, we do not analyze dynamic imports:

async function loadModule() {
    const myModule = await import('./myModule.js'); // dynamic import
    // code...
}

Should be added to isImportDeclaration probe.
@jean-michelet jean-michelet mentioned this issue Apr 20, 2024
Merged
@jean-michelet
Copy link
Contributor Author

Looking into it next week @fraxken

@jean-michelet jean-michelet mentioned this issue Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle ImportExpression nodes jean-michelet/js-x-ray
1 participant
@jean-michelet