Skip to content

Commit e5d6eb9

Browse files
committed
fix: more specific selectors, eslint
TODO: convert this to data-component (breaking change)
1 parent 0dd8193 commit e5d6eb9

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

static/lib/composer/categoryList.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@
33

44
/*globals define, socket, app*/
55

6-
define('composer/categoryList', ['categorySelector', 'taskbar'], function(categorySelector, taskbar) {
6+
define('composer/categoryList', ['categorySelector', 'taskbar'], function (categorySelector, taskbar) {
77
var categoryList = {};
88

99
var selector;
1010

11-
categoryList.init = function(postContainer, postData) {
11+
categoryList.init = function (postContainer, postData) {
1212
var listContainer = postContainer.find('.category-list-container');
1313
if (!listContainer.length) {
1414
return;
@@ -18,7 +18,7 @@ define('composer/categoryList', ['categorySelector', 'taskbar'], function(catego
1818
toggleDropDirection(postContainer);
1919
});
2020

21-
socket.emit('plugins.composer.getCategoriesForSelect', {}, function(err, categories) {
21+
socket.emit('plugins.composer.getCategoriesForSelect', {}, function (err, categories) {
2222
if (err) {
2323
return app.alertError(err.message);
2424
}
@@ -53,15 +53,15 @@ define('composer/categoryList', ['categorySelector', 'taskbar'], function(catego
5353

5454
var selectedCategory = selector.getSelectedCategory();
5555

56-
$('.category-name').translateText(selectedCategory ? selectedCategory.name : '[[modules:composer.select_category]]');
57-
$('.category-selector').find('li[data-cid="' + postData.cid + '"]').addClass('active');
56+
postContainer.find('.category-name').translateText(selectedCategory ? selectedCategory.name : '[[modules:composer.select_category]]');
57+
postContainer.find('.category-selector').find('li[data-cid="' + postData.cid + '"]').addClass('active');
5858

5959
toggleDropDirection(postContainer);
6060
});
6161
});
6262

6363

64-
$('.category-selector').on('click', 'li', function() {
64+
$('.category-selector').on('click', 'li', function () {
6565
$('.category-name').text($(this).text());
6666
$('.category-selector').removeClass('open');
6767
$('.category-selector li').removeClass('active');

0 commit comments

Comments
 (0)