the the fix (flutter#15973)

dnfield · NoamDev · commit be371e25db2d · 2020-02-27T19:50:26.000+02:00
diff --git a/common/settings.h b/common/settings.h
@@ -187,7 +187,7 @@ struct Settings {
   // Window.getPersistentIsolateData callback. This is meant for information
   // that the isolate cannot request asynchronously (platform messages can be
   // used for that purpose). This data is held for the lifetime of the shell and
-  // is available on isolate restarts in the the shell instance. Due to this,
+  // is available on isolate restarts in the shell instance. Due to this,
   // the buffer must be as small as possible.
   std::shared_ptr<const fml::Mapping> persistent_isolate_data;
 
diff --git a/flow/skia_gpu_object.h b/flow/skia_gpu_object.h
@@ -16,7 +16,7 @@
 
 namespace flutter {
 
-// A queue that holds Skia objects that must be destructed on the the given task
+// A queue that holds Skia objects that must be destructed on the given task
 // runner.
 class SkiaUnrefQueue : public fml::RefCountedThreadSafe<SkiaUnrefQueue> {
  public:
diff --git a/fml/gpu_thread_merger.h b/fml/gpu_thread_merger.h
@@ -36,7 +36,7 @@ class GpuThreadMerger : public fml::RefCountedThreadSafe<GpuThreadMerger> {
   GpuThreadMerger(fml::TaskQueueId platform_queue_id,
                   fml::TaskQueueId gpu_queue_id);
 
-  // Returns true if the the current thread owns rasterizing.
+  // Returns true if the current thread owns rasterizing.
   // When the threads are merged, platform thread owns rasterizing.
   // When un-merged, gpu thread owns rasterizing.
   bool IsOnRasterizingThread();
diff --git a/fml/platform/darwin/scoped_block.h b/fml/platform/darwin/scoped_block.h
@@ -19,7 +19,7 @@ enum class OwnershipPolicy {
   // ownership claim.
   Assume,
 
-  // The scoped object will retain the the object and any initial ownership is
+  // The scoped object will retain the object and any initial ownership is
   // not changed.
   Retain,
 };
diff --git a/lib/ui/painting.dart b/lib/ui/painting.dart
@@ -646,7 +646,7 @@ enum BlendMode {
   /// ![](https://flutter.github.io/assets-for-api-docs/assets/dart-ui/blend_mode_colorDodge.png)
   colorDodge,
 
-  /// Divide the inverse of the destination by the the source, and inverse the result.
+  /// Divide the inverse of the destination by the source, and inverse the result.
   ///
   /// Inverting the components means that a fully saturated channel (opaque
   /// white) is treated as the value 0.0, and values normally treated as 0.0
@@ -2118,7 +2118,7 @@ class Path extends NativeFieldWrapperClass2 {
   void _addPathWithMatrix(Path path, double dx, double dy, Float64List matrix) native 'Path_addPathWithMatrix';
 
   /// Adds the given path to this path by extending the current segment of this
-  /// path with the the first segment of the given path.
+  /// path with the first segment of the given path.
   ///
   /// If `matrix4` is specified, the path will be transformed by this matrix
   /// after the matrix is translated by the given `offset`.  The matrix is a 4x4
diff --git a/lib/ui/semantics.dart b/lib/ui/semantics.dart
@@ -471,7 +471,7 @@ class SemanticsFlag {
 
   /// Whether the semantics node represents an image.
   ///
-  /// Both TalkBack and VoiceOver will inform the user the the semantics node
+  /// Both TalkBack and VoiceOver will inform the user the semantics node
   /// represents an image.
   static const SemanticsFlag isImage = SemanticsFlag._(_kIsImageIndex);
 
diff --git a/lib/web_ui/dev/common.dart b/lib/web_ui/dev/common.dart
@@ -178,7 +178,7 @@ class BrowserInstallation {
   /// Browser version.
   final String version;
 
-  /// Path the the browser executable.
+  /// Path the browser executable.
   final String executable;
 }
 
diff --git a/lib/web_ui/lib/src/engine/semantics/scrollable.dart b/lib/web_ui/lib/src/engine/semantics/scrollable.dart
@@ -125,7 +125,7 @@ class Scrollable extends RoleManager {
   /// have zero offset relative to Flutter's notion of scroll position is
   /// referred to as "neutral scroll position".
   ///
-  /// We always set the the scroll position to a non-zero value in order to
+  /// We always set the scroll position to a non-zero value in order to
   /// be able to scroll in the negative direction. When scrollTop/scrollLeft is
   /// zero the browser will refuse to scroll back even when there is more
   /// content available.
diff --git a/lib/web_ui/lib/src/engine/surface/painting.dart b/lib/web_ui/lib/src/engine/surface/painting.dart
@@ -775,7 +775,7 @@ class SurfacePath implements ui.Path {
   }
 
   /// Adds the given path to this path by extending the current segment of this
-  /// path with the the first segment of the given path.
+  /// path with the first segment of the given path.
   ///
   /// If `matrix4` is specified, the path will be transformed by this matrix
   /// after the matrix is translated by the given `offset`.  The matrix is a 4x4
diff --git a/lib/web_ui/lib/src/engine/surface/surface.dart b/lib/web_ui/lib/src/engine/surface/surface.dart
@@ -741,7 +741,7 @@ abstract class PersistedSurface implements ui.EngineLayer {
     //                `false` for children. Or, which might be cleaner, we could
     //                split this method into two methods. One method will detach
     //                the DOM, and the second method will disassociate the
-    //                surface from the the DOM and release it irrespective of
+    //                surface from the DOM and release it irrespective of
     //                whether the DOM itself gets detached or not.
     rootElement.remove();
     rootElement = null;
diff --git a/lib/web_ui/lib/src/ui/painting.dart b/lib/web_ui/lib/src/ui/painting.dart
@@ -660,7 +660,7 @@ enum BlendMode {
   /// ![](https://flutter.github.io/assets-for-api-docs/assets/dart-ui/blend_mode_colorDodge.png)
   colorDodge,
 
-  /// Divide the inverse of the destination by the the source, and inverse the result.
+  /// Divide the inverse of the destination by the source, and inverse the result.
   ///
   /// Inverting the components means that a fully saturated channel (opaque
   /// white) is treated as the value 0.0, and values normally treated as 0.0
diff --git a/lib/web_ui/lib/src/ui/path.dart b/lib/web_ui/lib/src/ui/path.dart
@@ -211,7 +211,7 @@ abstract class Path {
   void addPath(Path path, Offset offset, {Float64List matrix4});
 
   /// Adds the given path to this path by extending the current segment of this
-  /// path with the the first segment of the given path.
+  /// path with the first segment of the given path.
   ///
   /// If `matrix4` is specified, the path will be transformed by this matrix
   /// after the matrix is translated by the given `offset`.  The matrix is a 4x4
diff --git a/lib/web_ui/lib/src/ui/semantics.dart b/lib/web_ui/lib/src/ui/semantics.dart
@@ -463,7 +463,7 @@ class SemanticsFlag {
 
   /// Whether the semantics node represents an image.
   ///
-  /// Both TalkBack and VoiceOver will inform the user the the semantics node
+  /// Both TalkBack and VoiceOver will inform the user the semantics node
   /// represents an image.
   static const SemanticsFlag isImage = SemanticsFlag._(_kIsImageIndex);
 
diff --git a/shell/common/engine.h b/shell/common/engine.h
@@ -161,7 +161,7 @@ class Engine final : public RuntimeDelegate, PointerDataDispatcher::Delegate {
     //--------------------------------------------------------------------------
     /// @brief      When the Flutter application has a message to send to the
     ///             underlying platform, the message needs to be forwarded to
-    ///             the platform on the the appropriate thread (via the platform
+    ///             the platform on the appropriate thread (via the platform
     ///             task runner). The engine delegates this task to the shell
     ///             via this method.
     ///
@@ -231,7 +231,7 @@ class Engine final : public RuntimeDelegate, PointerDataDispatcher::Delegate {
 
   //----------------------------------------------------------------------------
   /// @brief      Creates an instance of the engine. This is done by the Shell
-  ///             on the the UI task runner.
+  ///             on the UI task runner.
   ///
   /// @param      delegate           The object used by the engine to perform
   ///                                tasks that require access to components
@@ -370,7 +370,7 @@ class Engine final : public RuntimeDelegate, PointerDataDispatcher::Delegate {
   ///             Flutter application. This happens implicitly in the call to
   ///             `Engine::Run` and `Engine::Restart` as the asset manager is
   ///             referenced from the run configuration provided to those calls.
-  ///             In addition to the the `Engine::Run` and `Engine::Restart`
+  ///             In addition to the `Engine::Run` and `Engine::Restart`
   ///             calls, the tooling may need to update the assets available to
   ///             the application as the user adds them to their project. For
   ///             example, these assets may be referenced by code that is newly
diff --git a/shell/common/rasterizer.h b/shell/common/rasterizer.h
@@ -200,7 +200,7 @@ class Rasterizer final : public SnapshotDelegate {
   ///             This is used as an optimization in cases where there are
   ///             external textures (video or camera streams for example) in
   ///             referenced in the layer tree. These textures may be updated at
-  ///             a cadence different from that of the the Flutter application.
+  ///             a cadence different from that of the Flutter application.
   ///             Flutter can re-render the layer tree with just the updated
   ///             textures instead of waiting for the framework to do the work
   ///             to generate the layer tree describing the same contents.
diff --git a/shell/platform/darwin/ios/framework/Source/FlutterDartProject.mm b/shell/platform/darwin/ios/framework/Source/FlutterDartProject.mm
@@ -59,7 +59,7 @@
   // The command line arguments may not always be complete. If they aren't, attempt to fill in
   // defaults.
 
-  // Flutter ships the ICU data file in the the bundle of the engine. Look for it there.
+  // Flutter ships the ICU data file in the bundle of the engine. Look for it there.
   if (settings.icu_data_path.size() == 0) {
     NSString* icuDataPath = [engineBundle pathForResource:@"icudtl" ofType:@"dat"];
     if (icuDataPath.length > 0) {
diff --git a/shell/platform/embedder/embedder.cc b/shell/platform/embedder/embedder.cc
@@ -1665,7 +1665,7 @@ FlutterEngineResult FlutterEnginePostDartObject(
           SAFE_ACCESS(object->buffer_value, buffer_collect_callback, nullptr);
       auto user_data = SAFE_ACCESS(object->buffer_value, user_data, nullptr);
 
-      // The the user has provided a callback, let them manage the lifecycle of
+      // The user has provided a callback, let them manage the lifecycle of
       // the underlying data. If not, copy it out from the provided buffer.
 
       if (callback == nullptr) {
diff --git a/shell/platform/embedder/embedder.h b/shell/platform/embedder/embedder.h
@@ -1125,7 +1125,7 @@ typedef struct {
 
 //------------------------------------------------------------------------------
 /// @brief      Initialize and run a Flutter engine instance and return a handle
-///             to it. This is a convenience method for the the pair of calls to
+///             to it. This is a convenience method for the pair of calls to
 ///             `FlutterEngineInitialize` and `FlutterEngineRunInitialized`.
 ///
 /// @note       This method of running a Flutter engine works well except in
diff --git a/shell/platform/embedder/embedder_external_view_embedder.cc b/shell/platform/embedder/embedder_external_view_embedder.cc
@@ -191,7 +191,7 @@ bool EmbedderExternalViewEmbedder::SubmitFrame(GrContext* context) {
   if (!RenderPictureToRenderTarget(
           root_picture_recorder_->finishRecordingAsPicture(),
           root_render_target_.get())) {
-    FML_LOG(ERROR) << "Could not render into the the root render target.";
+    FML_LOG(ERROR) << "Could not render into the root render target.";
     return false;
   }
   // The root picture recorder will be reset when a new frame begins.
diff --git a/testing/lsan_suppressions.txt b/testing/lsan_suppressions.txt
@@ -31,7 +31,7 @@ leak:wrap_dispatch_source_set_event_handler
 leak:flutter::PlatformViewEmbedder::HandlePlatformMessage
 
 # Service ID platform message is leaked in case the isolate dies before the
-# message is received by the the same.
+# message is received by the same.
 # https://github.com/flutter/flutter/issues/42178
 leak:flutter::Engine::Run(flutter::RunConfiguration)
 
diff --git a/third_party/txt/src/minikin/Hyphenator.h b/third_party/txt/src/minikin/Hyphenator.h
@@ -167,7 +167,7 @@ class Hyphenator {
   // Try looking up word in alphabet table, return DONT_BREAK if any code units
   // fail to map. Otherwise, returns BREAK_AND_INSERT_HYPHEN,
   // BREAK_AND_INSERT_ARMENIAN_HYPHEN, or BREAK_AND_DONT_INSERT_HYPHEN based on
-  // the the script of the characters seen. Note that this method writes len+2
+  // the script of the characters seen. Note that this method writes len+2
   // entries into alpha_codes (including start and stop)
   HyphenationType alphabetLookup(uint16_t* alpha_codes,
                                  const uint16_t* word,
diff --git a/vulkan/vulkan_device.cc b/vulkan/vulkan_device.cc
@@ -318,7 +318,7 @@ bool VulkanDevice::ChoosePresentMode(const VulkanSurface& surface,
   // VK_PRESENT_MODE_FIFO_KHR is preferable on mobile platforms. The problems
   // mentioned in the ticket w.r.t the application being faster that the refresh
   // rate of the screen should not be faced by any Flutter platforms as they are
-  // powered by Vsync pulses instead of depending the the submit to block.
+  // powered by Vsync pulses instead of depending the submit to block.
   // However, for platforms that don't have VSync providers setup, it is better
   // to fall back to FIFO. For platforms that do have VSync providers, there
   // should be little difference. In case there is a need for a mode other than

Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,7 @@ class BrowserInstallation {`
`178`	`178`	`/// Browser version.`
`179`	`179`	`final String version;`
`180`	`180`
`181`		`- /// Path the the browser executable.`
	`181`	`+ /// Path the browser executable.`
`182`	`182`	`final String executable;`
`183`	`183`	`}`
`184`	`184`
Original file line number	Diff line number	Diff line change
`@@ -775,7 +775,7 @@ class SurfacePath implements ui.Path {`
`775`	`775`	`}`
`776`	`776`
`777`	`777`	`/// Adds the given path to this path by extending the current segment of this`
`778`		`- /// path with the the first segment of the given path.`
	`778`	`+ /// path with the first segment of the given path.`
`779`	`779`	`///`
`780`	`780`	/// If `matrix4` is specified, the path will be transformed by this matrix
`781`	`781`	/// after the matrix is translated by the given `offset`. The matrix is a 4x4