Refactor _placementInSuggestionList to not use the dart:math Point class to represent Place, this has been replaced by a new class.

Change-Id: I6750667e878e16c816caa80760fd8763bba97ccb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132780
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>

Author: jwren

pkg/analysis_server/tool/completion_metrics/completion_metrics.dart

@@ -4,7 +4,6 @@
 
 import 'dart:async';
 import 'dart:io' as io;
-import 'dart:math';
 
 import 'package:analysis_server/src/domains/completion/available_suggestions.dart';
 import 'package:analysis_server/src/protocol_server.dart';
@@ -83,7 +82,7 @@ Future _computeCompletionMetrics(
               var fraction =
                   _placementInSuggestionList(suggestions, expectedCompletion);
 
-              if (fraction.y != 0) {
+              if (fraction.denominator != 0) {
                 includedCount++;
               } else {
                 notIncludedCount++;
@@ -130,16 +129,16 @@ Future _computeCompletionMetrics(
   completionElementKindCounter.clear();
 }
 
-Point<int> _placementInSuggestionList(List<CompletionSuggestion> suggestions,
+Place _placementInSuggestionList(List<CompletionSuggestion> suggestions,
     ExpectedCompletion expectedCompletion) {
-  var i = 1;
+  var placeCounter = 1;
   for (var completionSuggestion in suggestions) {
     if (expectedCompletion.matches(completionSuggestion)) {
-      return Point(i, suggestions.length);
+      return Place(placeCounter, suggestions.length);
     }
-    i++;
+    placeCounter++;
   }
-  return Point(0, 0);
+  return Place.none();
 }
 
 Future<List<CompletionSuggestion>> computeCompletionSuggestions(

pkg/analysis_server/tool/completion_metrics/metrics_util.dart

@@ -3,6 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:analysis_server/src/status/pages.dart';
+import 'package:analyzer/src/generated/utilities_general.dart';
 
 /// A simple counter class.  A [String] name is passed to name the counter. Each
 /// time something is counted, a non-null, non-empty [String] key is passed to
@@ -54,3 +55,34 @@ class Counter {
     print('');
   }
 }
+
+/// An immutable class to represent the placement in some list, for example '2nd
+/// place out of 5'.
+class Place {
+  /// A 1-indexed place in a list
+  final int _numerator;
+
+  /// The total number of possible places.
+  final int _denominator;
+
+  Place(this._numerator, this._denominator) {
+    assert(_numerator > 0 && _denominator > 0);
+  }
+
+  Place.none()
+      : _numerator = 0,
+        _denominator = 0;
+
+  int get denominator => _denominator;
+
+  @override
+  int get hashCode => JenkinsSmiHash.hash2(_numerator, _denominator);
+
+  int get numerator => _numerator;
+
+  @override
+  bool operator ==(dynamic other) =>
+      other is Place &&
+      _numerator == other._numerator &&
+      _denominator == other._denominator;
+}