Skip to content

Commit 07c4ce9

Browse files
authored
Merge pull request #22 from NoCompromises/tweaks
few small tweaks
2 parents 7e45c0a + 012cc13 commit 07c4ce9

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

README_TEMPLATE.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,9 @@ If you don't want to run `dnsmasq`, you can also add a manual DNS entry to your
4141

4242
### Setting up an SSL certificate
4343

44-
First, you'll need to create an SSL certificate that can be used inside Docker. We'll use `mkcert`, a simple tool for
45-
making locally-trusted development certificates.
44+
Orbstack provides automatic TLS certificates for `.local` domains, but we will also need to create one that Vite can use.
45+
46+
To do this, we'll use `mkcert`, a simple tool for making locally-trusted development certificates.
4647

4748
To install on Mac with Homebrew, you can run:
4849

@@ -61,6 +62,8 @@ Then, generate the certificates for this project and put them into a location ac
6162

6263
`mkcert -cert-file docker/vite/ssl.pem -key-file docker/vite/key.pem my-project.test`
6364

65+
We're using the `.test` top-level domain for the Vite server.
66+
6467
### Node environment
6568
The best option to ensure you're using the correct versions of Node and npm with this project is to install [Volta](https://volta.sh).
6669
Volta will read the pinned versions of Node and npm from the `package.json` so you can be sure you're using the correct versions.

docker/php-fpm/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM php:8.3.8-fpm-alpine3.20 as base
1+
FROM php:8.3.11-fpm-alpine3.20 AS base
22

33
RUN apk add --no-cache $PHPIZE_DEPS \
44
freetype-dev \
@@ -21,7 +21,7 @@ COPY --from=composer:2.7.7 /usr/bin/composer /usr/bin/composer
2121

2222
COPY docker-php-file-uploads.ini /usr/local/etc/php/conf.d/docker-php-file-uploads.ini
2323

24-
FROM base as debug
24+
FROM base AS debug
2525

2626
# Supports xdebug
2727
RUN apk add --update linux-headers

0 commit comments

Comments
 (0)