Skip to content

Commit ea2a677

Browse files
committed
refactor: code clean up
1 parent 9931e12 commit ea2a677

File tree

1 file changed

+8
-14
lines changed
  • app/src/main/java/com/example/diff_utils_recyclerview_example/ui

1 file changed

+8
-14
lines changed

app/src/main/java/com/example/diff_utils_recyclerview_example/ui/MainActivity.kt

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,10 @@
11
package com.example.diff_utils_recyclerview_example.ui
22

3-
import androidx.appcompat.app.AppCompatActivity
43
import android.os.Bundle
5-
import android.view.LayoutInflater
6-
import android.widget.Toast
7-
import android.widget.Toast.makeText
84
import androidx.activity.viewModels
9-
import androidx.lifecycle.ViewModel
10-
import androidx.lifecycle.lifecycleScope
5+
import androidx.appcompat.app.AppCompatActivity
116
import androidx.recyclerview.widget.LinearLayoutManager
127
import androidx.recyclerview.widget.RecyclerView
13-
import com.example.diff_utils_recyclerview_example.R
148
import com.example.diff_utils_recyclerview_example.databinding.ActivityMainBinding
159
import com.example.diff_utils_recyclerview_example.ui.adapters.CharactersAdapter
1610
import com.example.diff_utils_recyclerview_example.ui.viewmodel.fetchCharactersViewModel
@@ -20,8 +14,8 @@ import dagger.hilt.android.AndroidEntryPoint
2014
@AndroidEntryPoint
2115
class MainActivity : AppCompatActivity() {
2216
private lateinit var binding: ActivityMainBinding
23-
private lateinit var charactersAdapter:CharactersAdapter
24-
private val charactersViewModel: fetchCharactersViewModel by viewModels()
17+
private lateinit var charactersAdapter: CharactersAdapter
18+
private val charactersViewModel: fetchCharactersViewModel by viewModels()
2519

2620
override fun onCreate(savedInstanceState: Bundle?) {
2721
super.onCreate(savedInstanceState)
@@ -30,14 +24,14 @@ class MainActivity : AppCompatActivity() {
3024

3125
charactersAdapter = CharactersAdapter()
3226
var recyclerView = binding.rvCharacters
33-
recyclerView.layoutManager = LinearLayoutManager(this,RecyclerView.VERTICAL,false)
27+
recyclerView.layoutManager = LinearLayoutManager(this, RecyclerView.VERTICAL, false)
3428
recyclerView.adapter = charactersAdapter
3529

36-
charactersViewModel.fetchCharacters.observe(this){
37-
charactersAdapter.saveData(it.data)
30+
charactersViewModel.fetchCharacters.observe(this) {
31+
charactersAdapter.saveData(it.data)
3832
}
39-
charactersViewModel.errorResponse.observe(this){errorMessage ->
40-
Snackbar.make(binding.root,errorMessage.toString(),Snackbar.LENGTH_SHORT).show()
33+
charactersViewModel.errorResponse.observe(this) { errorMessage ->
34+
Snackbar.make(binding.root, errorMessage.toString(), Snackbar.LENGTH_SHORT).show()
4135
}
4236
charactersViewModel.getCharacters()
4337
}

0 commit comments

Comments
 (0)