Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Remove .NET Standard 1.x/.NET Core 1.x build features #72

Closed
NightOwl888 opened this issue Sep 22, 2024 · 0 comments · Fixed by #74
Closed

Task: Remove .NET Standard 1.x/.NET Core 1.x build features #72

NightOwl888 opened this issue Sep 22, 2024 · 0 comments · Fixed by #74
Assignees

Comments

@NightOwl888
Copy link
Owner

There are several features that are still hanging around even though we dropped support for .NET Core 1.x and .NET Standard 1.x years ago. These can be removed, which will help us simplify maintenance.

<!-- Features in .NET Standard 1.x and .NET Core 1.x -->
<PropertyGroup Condition=" $(TargetFramework.StartsWith('netstandard1.')) Or $(TargetFramework.StartsWith('netcoreapp1.')) ">
<DefineConstants>$(DefineConstants);NETSTANDARD1_X</DefineConstants>
<DefineConstants>$(DefineConstants);NETCOREAPP1_X</DefineConstants>
<DefineConstants>$(DefineConstants);FEATURE_CULTUREINFO_UNKNOWNLANGUAGE</DefineConstants>
<DefineConstants>$(DefineConstants);FEATURE_TYPEEXTENSIONS_GETTYPEINFO</DefineConstants>
<DefineConstants>$(DefineConstants);FEATURE_CULTUREINFO_DEFAULTTHREADCURRENTCULTURE</DefineConstants>
<DefineConstants>$(DefineConstants);FEATURE_EXCEPTION_HRESULT</DefineConstants>
<DefineConstants>$(DefineConstants);FEATURE_MICROSOFT_EXTENSIONS_CACHING</DefineConstants>
<DefineConstants>$(DefineConstants);FEATURE_IREADONLYCOLLECTIONS</DefineConstants>
<DefineConstants>$(DefineConstants);FEATURE_REGEX_MATCHTIMEOUT</DefineConstants>
<DefineConstants>$(DefineConstants);FEATURE_TASK_ASYNC_AWAIT</DefineConstants>
<DefineConstants>$(DefineConstants);FEATURE_TASK_RUN</DefineConstants>
<DefineConstants>$(DefineConstants);FEATURE_TYPEDWEAKREFERENCE</DefineConstants>
</PropertyGroup>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant